Skip to content

refactor: update typehints in workflows/cloud-client #9967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2023
Merged

Conversation

Sita04
Copy link
Collaborator

@Sita04 Sita04 commented May 16, 2023

Description

b/280881575 : Update type hints in workflows/cloud-client.

Checklist

@Sita04 Sita04 requested a review from a team as a code owner May 16, 2023 15:46
@snippet-bot
Copy link

snippet-bot bot commented May 16, 2023

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels May 16, 2023
Copy link
Contributor

@kweinmeister kweinmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Can you please add a Noxfile to enforce type hints? This will test your changes, and will ensure they are enforced in the future. Here's an example file which should work as-is.

@Sita04
Copy link
Collaborator Author

Sita04 commented May 16, 2023

Done, thanks Karl.

Copy link
Contributor

@kweinmeister kweinmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Can you please add a Noxfile to enforce type hints? This will test your changes, and will ensure they are enforced in the future. Here's an example file which should work as-is.

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit c5c3869 into main May 16, 2023
@engelke engelke deleted the workflows-update branch May 16, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants