-
Notifications
You must be signed in to change notification settings - Fork 6.5k
refactor: update typehints in workflows/cloud-client #9967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Can you please add a Noxfile to enforce type hints? This will test your changes, and will ensure they are enforced in the future. Here's an example file which should work as-is.
Done, thanks Karl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Can you please add a Noxfile to enforce type hints? This will test your changes, and will ensure they are enforced in the future. Here's an example file which should work as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
b/280881575 : Update type hints in workflows/cloud-client.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)