Add contribution guidelines #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add link to contribution guidelines
- ignores memebers of the org from signing off
- Added to ignore .github and other files from npm package
markdirish
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
This all looks really good. Do we also need a CONTRIBUTORS.md/txt? Never mind, seems one was added 2 years ago!
Only thing I noticed is the max-line length in CONTRIBUTING.md seems to be applied inconsistently, some lines break much sooner than others. Not sure what is causing it, not is it a huge deal, so approving!
|
Thanks for Reviewing, I will merge it in |
jkdavew
pushed a commit
to jkdavew/nodejs-itoolkit
that referenced
this pull request
Feb 28, 2019
* Add contribution guidelines * Update README.md - Add link to contribution guidelines * Add dco bot config - ignores members of the org from signing off * Add .npmignore - Added to ignore .github and other files from npm package Signed-off-by: Dave Weissman <[email protected]>
jkdavew
pushed a commit
to jkdavew/nodejs-itoolkit
that referenced
this pull request
Feb 28, 2019
* Add contribution guidelines * Update README.md - Add link to contribution guidelines * Add dco bot config - ignores members of the org from signing off * Add .npmignore - Added to ignore .github and other files from npm package Signed-off-by: Dave Weissman <[email protected]>
jkdavew
pushed a commit
to jkdavew/nodejs-itoolkit
that referenced
this pull request
Feb 28, 2019
* Add contribution guidelines * Update README.md - Add link to contribution guidelines * Add dco bot config - ignores members of the org from signing off * Add .npmignore - Added to ignore .github and other files from npm package Signed-off-by: Dave Weissman <[email protected]>
jkdavew
pushed a commit
to jkdavew/nodejs-itoolkit
that referenced
this pull request
Feb 28, 2019
* Add contribution guidelines * Update README.md - Add link to contribution guidelines * Add dco bot config - ignores members of the org from signing off * Add .npmignore - Added to ignore .github and other files from npm package Signed-off-by: Dave Weissman <[email protected]>
jkdavew
pushed a commit
to jkdavew/nodejs-itoolkit
that referenced
this pull request
Mar 2, 2019
* Add contribution guidelines * Update README.md - Add link to contribution guidelines * Add dco bot config - ignores members of the org from signing off * Add .npmignore - Added to ignore .github and other files from npm package Signed-off-by: Dave Weissman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing contribution guidelines as well as config for DCO bot.
Along the way:
updated README to link to contribution guidelines
.npmignore to ignore .github/ and other files
Once merged I will make a request to setup the DCO bot