Merge in Tests and changes from Master #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests added for - iSh, iQsh, iCmd function (commandsUnit.js) - iConn methods, stubbed out run method - iPgm methods - iSql methods - xmlToJson function Functional tests added for - iDataQueue Class methods - iNetwork Class methods - iObj methods - iPgm methods - iProd methods - iSql methods - iUserSpace methods - iWork methods Removed test.js - Moved functional tests from test.js to the appropriate class test Added utils.js - contains helper function return transports - returns iConn objects intialized to transports - used to dynamically generate functional tests that only differ by iConn object used for transport Added test/README.md - provides instructions to setup and run tests - lists available environment variables to configure tests
ixml.js - line 293 changed const to let ran into reassignment error with const - changed iXmlNodeSqlParmOpen set io attribute, incorrectly set name attribute before xmlToJson - When converting <sql> xmlOut stmt: property would return ']]>' from CDATA output - Example: "stmt":"SELECT '' AS BLANK, STATE FROM QIWS.QCUSTCDT]]>" - Not sure if every version of XMLSERVICE adds CDATA to returned statement. - Added a check to see if the matched success string contains CDATA and replaced extra characters. iConn.setTimeout() - could not be set, if condition checked flag instead of seconds iSql.rowCount() - added check to allow optional options object iSql.count() - called iXmlNodeSqlRowCount instead of iXmlNodeSqlCount iProd.getProductInfo - Fixed issue that occured when calling with (productId, cb) signature - the callback function definition was being appended to the options causing the pgm call to fail
- moved idb-connector to optional deps - added idb-pconnector to optional deps - added sinon - for (mocking/stubs) to dev deps
Add Unit and Functional Tests
* Add contribution guidelines * Update README.md - Add link to contribution guidelines * Add dco bot config - ignores members of the org from signing off * Add .npmignore - Added to ignore .github and other files from npm package
- merged in functional and unit tests - merged in small patches found while unit testing - merged contribution guidlines and related files
Updated how the underlying properties was accessed in iConnUnit.js Touched up the require() path to find the modules for - iDataQueueFunctional - iNetworkFunctional - iObjFunctional - iProdFunctional - iUserSpaceFunctional - iWorkFunctional Toolkit.js - uncommented Release_level property in getProductInfo() - fixed require() statement for ProgramCall Connection.js - fix variable name change iXml_SERVICE_LIB -> I_XML_SERVICE_LIB Deprecated.js - add missing addToLibraryList() function - add missing getJobInfo() function - fixed typo retSrvPgmIfno -> retSrvPgmInfo - fixed typo retUserIfno -> retrUserInfo - fixed typo getSysStatysEx -> getSysStatusExt Update ixml.js - ran into error when options was undefined in iXmlNodeDataOpen - added guard to iterate over keys only when options is an object
- use Connection instead of iConn for transports
markdirish
suggested changes
Feb 27, 2019
- itoolkit.js - ixml.js
I think this got introduced when merging with master. Added commit to resolve issue. |
markdirish
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged in functional and unit tests from master as well as small patches found while testing, see PR #34
Also merged in contribution guidelines from master see PR #37.
After merging I ran the unit anf functional tests to ensure they passed.
Most did but found some issues that I fixed up in commit b14ec35.
Now tests are passing within v1.0-dev.