Skip to content

Send tokens from webserver -> storage #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pcrespov opened this issue Nov 26, 2018 · 0 comments · Fixed by #380
Closed

Send tokens from webserver -> storage #369

pcrespov opened this issue Nov 26, 2018 · 0 comments · Fixed by #380
Assignees
@pcrespov
Milestone
Sagittaron

Comments

@pcrespov
Copy link
Member

the cleanest and fastest solution is to send the tokens on every call from webserver->storage ... the same way we do with the userid!

These can also go as part of the headers (get operations have them as well) or in some cookies... so they get bounced back and forward?

Child of #240
@pcrespov pcrespov added this to the Sagittaron milestone Nov 26, 2018
@pcrespov pcrespov self-assigned this Nov 26, 2018
@pcrespov pcrespov added backlog and removed backlog labels Nov 26, 2018
@pcrespov pcrespov mentioned this issue Nov 29, 2018
Merged
8 tasks
@ghost ghost added review and removed in progress labels Nov 29, 2018
pcrespov added a commit that referenced this issue Nov 30, 2018
@pcrespov
Is369/storage tokens (#380)
605a2ae 
* storage can access the user's datcore tokens info
 -  storage service retrieves user token's key and secret when it needs to operate on external services
 -  finishes implementation calls to list datcore from wrapper
 -  fixes on front-end (@odeimaiz )

* closes #369

* merged squashed is309/storage-api-spec from PR #366 (pending review but tests passing)

* Removed session from storage. not needed.

* Cleanup storage submodule in web-server
 - adds body in request

* Injected datcore tokens into dsm

* renamed:    db_helpers.py -> db_tokens.py


* Fixed dev-config in storage (does not have entire root folder inside of the container!)
Added acces stdin_open and tty to attach for debuggin


* Fixes pytest warning
 "cannot collect test class 'TestClient' because it has a __init__ constructor"

Pytest tries to collect TestClient as its name matches the naming conventions for test classes. However it finds a __init__ method, which it cannot understand.

* Modified storage config schemas on datcore test tokens

* Does not update dsm.datcore_tokens if not not available

* Fixes case of empty token match

* Injects dummy tokens table to init postgres fixture
userid is an integer but not a string
removed deprecated @pytest.mark.asyncio
@ghost ghost removed the review label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcrespov pcrespov

Labels
None yet
Projects
None yet
Milestone
Sagittaron
Development

Successfully merging a pull request may close this issue.

Is369/storage tokens pcrespov/osparc-simcore
1 participant
@pcrespov