Is309/storage api specs #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 21, 2018 11:58
Removed reference to oas3 in setup.py Added config rest section to set the remote or local location of apispecs repo rest.py loads oas doc, validates and proceeds with setup as before Oas3 is not anymore a resource. Removed all references as a resource Cleanup - removed cyclic dependency in settings - renamed settings_config as config_schema
- Adds workspace variables in config-files - Update config files with new section - Adds APIHUB_HOST, _PORT in storage docker-compose - Fixes duplication of docker-compose storage service
Copied changes in storage files from PR ITISFoundation#355 - commit ff814d9
adapting tests: - Adds new environ variables in tests fixtures - adds new config section
ghost
assigned 
mguidon
approved these changes
Nov 26, 2018
pcrespov
pushed a commit
to pcrespov/osparc-simcore
that referenced
this pull request
Nov 26, 2018
…nding review but tests passing)
sanderegg
requested changes
Nov 26, 2018
- Added loop dependency (might help in windows version) - cleanup tests_registry_proxy.py
sanderegg
approved these changes
Nov 27, 2018
pcrespov
added a commit
that referenced
this pull request
Nov 30, 2018
* storage can access the user's datcore tokens info - storage service retrieves user token's key and secret when it needs to operate on external services - finishes implementation calls to list datcore from wrapper - fixes on front-end (@odeimaiz ) * closes #369 * merged squashed is309/storage-api-spec from PR #366 (pending review but tests passing) * Removed session from storage. not needed. * Cleanup storage submodule in web-server - adds body in request * Injected datcore tokens into dsm * renamed: db_helpers.py -> db_tokens.py * Fixed dev-config in storage (does not have entire root folder inside of the container!) Added acces stdin_open and tty to attach for debuggin * Fixes pytest warning "cannot collect test class 'TestClient' because it has a __init__ constructor" Pytest tries to collect TestClient as its name matches the naming conventions for test classes. However it finds a __init__ method, which it cannot understand. * Modified storage config schemas on datcore test tokens * Does not update dsm.datcore_tokens if not not available * Fixes case of empty token match * Injects dummy tokens table to init postgres fixture userid is an integer but not a string removed deprecated @pytest.mark.asyncio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Moves storage service openapi specs into
api/specsRelated issue number
connected to #309
It is the last service, so closes #309
Checklist