Skip to content

Export group #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 568 commits into from
Mar 16, 2020
Merged

Export group #1266

merged 568 commits into from
Mar 16, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 29, 2020

What do these changes do?

1st version of group/dag export.

  • One can create a group/dag by clicking Export in the NodesTree (C).
  • Groups are listed in the catalog and in the service browser (R).
  • The creator/owner can delete it (D).

Bonus

  • One can show/readOnly/hide settings of an existing form
  • Got rid of the frontend compiler harmless error about the missing boot.js
  • Restart iframe button moved to the iFrame
  • Retrieve all button added to groups with at least one dynamic inner node
  • Auto.js and PropFrom.js refactoring
  • Services' Log Level can be set from env variable

Related issue number

related to ITISFoundation/osparc-issues#18
closes #1364

How to test

  • Select a group in the NodesTree
  • Click Export. What happens behind the scenes:
    • A copy of the inner nodes is made so that values and access levels can be modified
    • If any of them was connected to a non inner node, that connection is removed
  • The inputs of the copied inner nodes are shown
  • Before exporting, the user can play with the values and access level of those inputs
  • Click Export and reuse it in a study

Create and use
ExportGroup

Delete
ExportGroup2

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@ef492bd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1266   +/-   ##
=========================================
  Coverage          ?   72.56%           
=========================================
  Files             ?      201           
  Lines             ?     8437           
  Branches          ?      947           
=========================================
  Hits              ?     6122           
  Misses            ?     2037           
  Partials          ?      278
Flag Coverage Δ
#integrationtests 57.57% <ø> (?)
#unittests 66.7% <ø> (?)
Impacted Files Coverage Δ
services/catalog/src/simcore_service_catalog/db.py 87.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef492bd...86ff81e. Read the comment docs.

@odeimaiz odeimaiz self-assigned this Jan 29, 2020
@odeimaiz odeimaiz added this to the Mithos milestone Jan 29, 2020
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Feb 3, 2020
@odeimaiz odeimaiz merged commit 5932f7f into ITISFoundation:master Mar 16, 2020
@odeimaiz odeimaiz deleted the feature/export-group branch November 26, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot return to workbench in new full-screen mode
4 participants