Skip to content

Freeze chrigel maurer v0 #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 100 commits into from
May 26, 2020
Merged

Freeze chrigel maurer v0 #1529

merged 100 commits into from
May 26, 2020

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 26, 2020

dependabot-preview bot and others added 30 commits March 2, 2020 21:21
* Upgrades reqs due to vulnerability issue with pyaml

* Updated main doc and removed unresponsive badges
* script to remove duplicate project_id/node_id from comp_tasks table
* add start/stop time of sidecar computations
* added watchmedo in sidecar for faster development
* fixes #455
* log formatting give name of file and lineno
* increase log verbosity
)

* refactor github actions to have one file for PR/Push
* only run release actions on staging branch with the defined tag
* renaming script extension of bash scripts to .bash
* shellcheck
* check number of files in output
* fixes ujson missing dependency

* adds target to access shell

* Fixes ujson missing dependency

* Adds shell access for manual testing

* Adds minimal testing to avoid ujson to fail again

* Moved docker test to system

* Refactor test_service_images
Uses osparc_deploy fixture

* Refined test_ujson_installation
…le (#1342)

- Black-formatted ALL python: 
  - added auto-formatter in project makefiles
  - formatted every relevant python package or service
- scripts/common.Makefile collects common recipes: see how services and packages Makefiles are now simplified
- Fixed noisy pprint in the logs
- Added extensions to bash scripts
* Synced missing schema updates

* Updates apk management
Adds apk update in all dockers and basic client libs

* upgrades pip to ~=20.0.0
Bumps [ujson](https://github.com/ultrajson/ultrajson) from 1.35 to 2.0.1.
- [Release notes](https://github.com/ultrajson/ultrajson/releases)
- [Commits](ultrajson/ultrajson@v1.35...2.0.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
- check returned exceptions from asyncio.gather
- check future exceptions using a callback fct on futures to check if an exception occured and report it
* Tests how to count with aiopg

* Pre-check before write task in comp_tasks table
Previous logic would fill the postgres service log with errors.
This solution is more quite
Created subfunctions to separate logic

* Updated tests requirements in services

* Updated tests requirements for packages

* Updates test reqs for other tests folders

* Maintenance: Removed unused code

* Tunes log levels

* Improves migration CLI
* Reduced to only two background color for NodeUI
* Removed NodeUI tri-state.
* Buttons in ControlsBar are stacked to the right
* Showing Tags and creator information at the same time
* Fixed bug with hints not showing when used inside a window (zindex problem)
…ng the pipeline (#1316)

* Studies of one node open directly in that node
* autoOpenNode added to preferences
* catch exception on sockteio connection
Upgrades due to vulnerabilities;
* urllib3
* psutil CVE-2019-18874
Bumps [coverage](https://github.com/nedbat/coveragepy) from 4.5.1 to 5.0.3.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@coverage-4.5.1...coverage-5.0.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
ignapas and others added 21 commits May 12, 2020 10:42
* Auto JSONSchema forms
* Updated api specs

Co-authored-by: Katie Zhuang <[email protected]>
Co-authored-by: odeimaiz <[email protected]>
Co-authored-by: Pedro Crespo <[email protected]>
* avoids GC removing projects when  not guest

* added tests to catch any future issues

* [ci skip] fixed comments

* fixed docker file correctly colone and build

* added postress upgrade logs after the task is over
helps debugging the upgrade

* ops, how did these got here, reverting

* fixed intendation

Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Odei Maiz <[email protected]>
* avoids GC removing projects when  not guest

* added tests to catch any future issues

* [ci skip] fixed comments

* refactored test
- applied black reformatting
- merged 2 tests

Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Odei Maiz <[email protected]>
* added base CONTRIBUTING.md guidelines as a template

* new branch created

* added checksum check to docker-compose download

- if download fails (eg: github is not 100% up) this will avoid unexpected problems down the line

* added project specific notes to the CONTRIBUTING.md guidelines

* added other requested dependencies

* added reference to contributing page

* updated readme

* added PR review suggestions  to CONTRIBUTING.md

* renaming

* added more beginner friendly FAQs

* linking code conventions as FAQ

* added squash instructions

* added references to coding sytles and linters

* added docs on protection against upstream pushing

* linked no upstream push + tech specs & tech eval

* unused, removed

* linked comp. services overview and fixed a link

* added some videos to the FAQs

* added tip to apply migrations

Co-authored-by: Andrei Neagu <[email protected]>
* Adds target upgread in batch upgrades

* Upgrades pytest in all packages

* Upgrades pytest in catalog service

* upgrades pytest in director

* Upgrades pytest in sidecar

* upgrades pytest in storage

* Upgrades pytest in web-server

* Upgraded pytest in system tests
)

* renew cache in the background instead of clearing cache
* add 10% sleep time in test_registry
* Alignments
* Study Sheet redesigned
* Create New Study -> Empty Study
* use File related icons in study sheets
* Build layout qooxdoo style
* arrow added to Dashboard button
upgrade to latest Fake and redis packages (replaces faulty PR #1501) both in packages and services/web/server
upgrades api/tests requirements and Makefile
upgrades missing requirements from non-packages/services folders (e.g. coverage, pytest)
* pylint will now output the error + where to look

* keep alive will now be correctly set
avoids creating corrupted keys

* adjusted a couple of missing splits

* refactored pylint assert test (maybe)

* added missing requirement for testing and dev

* removing 1 level of search depth

* installing in editable mode

* added missing dependency to catalog

* added depoendencies for service-library

* fixing paths

* added storage service missing requirements

* fixed naming, it is now clearer

* triggering a new build

* enhanced output

Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Odei Maiz <[email protected]>
* Brought back the hover functions on the Study sheets
* sidePanel on the left
* Fix dashboard button issue
* Caret on the left side
* hide Stop button
* Logger collapsed by default (not for testers)
Fixes issue with cc human tutorial 
 Results were not updated

* Changed web-api doc to /webapi/doc
- avoids /api/ which already routed by traffik

* updates node outputs in project
This entry is NOT replaced but updated at the level of "output-name".
The data of a give output is obviously replaced.

* Minor formatting

* Cleaning up test_sidecar

* Fixes upload-files with nodeports: nodeports is not concurrent-safe, cannot use asyncio.gather to update each output ports, i.e await output.set

* For development, sets a single sidecar to debug
* setting instrumentation for cs services through sidecar, rabbit, webserver
* setting instrumentation for dynamic services through director /metrics endpoint
- All new services spawned by the director have a new tag called SWARM_STACK_NAME which represents the deployment. This way containers can be removed safely between environments. Note: old services must manually be removed on all environments as discussed with @sanderegg
- A container is considered orphaned when its node_id is not present in the database
- A container is considered orphaned when its node_id is not present in the current open projects
- Garbage collector is restarted after upon error except asyncio.CancelledError when it will be closed

NOTE: forced merge since travis did a strange dual PR build where both are green but prevent merging as usual.
- Minor or Patch upgrades for libraries within python packages or system/api testing requirements:
   - sqlalchemy patch 1.3.17
   - multidict
- packaging and more-itertools (for testing via pytest)
- Enhance scripts/requirements/Makefile to automate this job
- Prepares for pylint upgrade: cleanup of ignore rules in tests
- Autoformat cleanup
- Removes old deprectaed code web/server/tests/sandbox
* Only testers can create templates
* Save also tags when creating templates
* Hide description from template card
* get rid of compiling warnings
* hook to make markdown links open a new tab
* hook to make markdown links have proper color
* Fix for is1499
* fix e2e (#9)
* Added README to e2e testing
* Solved bug with rotating Idle icon
* Disabled no-eq-null rule to be able to check for null or undefined
* Added e2e debug config to vscode templates. Moved gitignores to new file
* Allowed new gitignores
* Continue button in feedback dialog now closes the window

Co-authored-by: Odei Maiz <[email protected]>
* Bound node's Interactive Status + Label in loading page
* Fixed PointEventPosition
* Keep aspect ratio
* Well centered Thumbnail class created
* StudyBrowserButtonBase uses our Thumbnail
will trigger gc in next 2 cycles at most

Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Odei Maiz <[email protected]>
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #1529 into staging will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           staging    #1529   +/-   ##
========================================
  Coverage    70.92%   70.92%           
========================================
  Files          249      249           
  Lines        10101    10101           
  Branches      1114     1114           
========================================
  Hits          7164     7164           
  Misses        2616     2616           
  Partials       321      321           
Flag Coverage Δ
#integrationtests 57.72% <0.00%> (ø)
#unittests 62.95% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e053bc...2e053bc. Read the comment docs.

@sanderegg sanderegg requested review from odeimaiz and pcrespov May 26, 2020 13:55
@sanderegg sanderegg self-assigned this May 26, 2020
@sanderegg sanderegg added this to the Chrigel Maurer milestone May 26, 2020
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add the list of changes

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo!

@sanderegg sanderegg merged commit 485d4a6 into staging May 26, 2020
@sanderegg sanderegg deleted the FREEZE_ChrigelMaurer_v0 branch May 26, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants