-
Notifications
You must be signed in to change notification settings - Fork 28
Fine Grained access rights #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine Grained access rights #1310
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1310 +/- ##
=======================================
Coverage 59.33% 59.33%
=======================================
Files 187 187
Lines 7351 7351
Branches 798 798
=======================================
Hits 4362 4362
Misses 2776 2776
Partials 213 213
Continue to review full report at Codecov.
|
…ghts Odeimaiz feature/user access rights
…ghts - fixes call to create as_template not passing the uuid - fixes cloning of project not changing the path to simcore-s3 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well done guys! Excellent work in a record time!
...simcore_postgres_database/migration/versions/53e095260441_add_projects_access_rights_and_.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/groups.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/groups.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
with pytest.raises(UniqueViolation, match="user_to_groups_uid_gid_key"): | ||
await conn.execute( | ||
user_to_groups.insert().values(uid=ringo.id, gid=rory_group.gid) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting what one can learn about music history during code reviews...
What do these changes do?
Frontend
Database: (by @sanderegg)
Webserver: (by @sanderegg)
Bonus
Related issue number
ITISFoundation/osparc-issues#22
closes #1437
closes #1344
closes #1459
closes #1486
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)