Skip to content

Studies of one node open directly in fullscreen view instead displaying the pipeline #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 12, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 26, 2020

What do these changes do?

When opening a study, if it only contains one node or one node connected to a file picker(s), it gets open automatically.

This feature can be disabled in the Preferences. Default set to True.

Related issue number

closes ITISFoundation/osparc-issues#144

OpenOne

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #1316 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1316      +/-   ##
==========================================
+ Coverage   72.63%   72.66%   +0.03%     
==========================================
  Files         201      201              
  Lines        8426     8426              
  Branches      945      945              
==========================================
+ Hits         6120     6123       +3     
+ Misses       2029     2027       -2     
+ Partials      277      276       -1     
Flag Coverage Δ
#integrationtests 57.56% <ø> (ø)
#unittests 66.80% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 67.01% <0.00%> (+0.25%) ⬆️
...tor/src/simcore_service_director/registry_proxy.py 70.46% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e8778...1862e40. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #1316 into master will decrease coverage by 15.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1316       +/-   ##
===========================================
- Coverage   73.14%   57.88%   -15.26%     
===========================================
  Files         199       87      -112     
  Lines        8310     3493     -4817     
  Branches      934      397      -537     
===========================================
- Hits         6078     2022     -4056     
+ Misses       1956     1377      -579     
+ Partials      276       94      -182     
Flag Coverage Δ
#integrationtests ?
#unittests 57.88% <ø> (-9.24%) ⬇️
Impacted Files Coverage Δ
packages/simcore-sdk/src/simcore_sdk/config/db.py 37.50% <0.00%> (-62.50%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 24.61% <0.00%> (-56.93%) ⬇️
...core-sdk/src/simcore_sdk/node_ports/filemanager.py 22.22% <0.00%> (-54.77%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/dbmanager.py 28.37% <0.00%> (-52.71%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/nodeports.py 27.77% <0.00%> (-47.78%) ⬇️
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 50.46% <0.00%> (-43.00%) ⬇️
...sdk/src/simcore_sdk/node_ports/data_items_utils.py 62.50% <0.00%> (-37.50%) ⬇️
...mcore-sdk/src/simcore_sdk/node_ports/exceptions.py 59.09% <0.00%> (-13.64%) ⬇️
...core-sdk/src/simcore_sdk/models/pipeline_models.py 50.00% <0.00%> (-12.50%) ⬇️
...k/src/simcore_sdk/node_ports/_schema_items_list.py 91.30% <0.00%> (-8.70%) ⬇️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae7b7d...a40c6cc. Read the comment docs.

@odeimaiz odeimaiz self-assigned this Feb 26, 2020
@odeimaiz odeimaiz added this to the Mithos milestone Feb 26, 2020
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Feb 26, 2020
@odeimaiz odeimaiz changed the title Feature/open one node Open one node Feb 26, 2020
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great but is it not a bit confusing?

@pcrespov pcrespov changed the title Open one node Studies of one node open directly in fullscreen view instead of in the dashboard Feb 26, 2020
@pcrespov pcrespov changed the title Studies of one node open directly in fullscreen view instead of in the dashboard Studies of one node open directly in fullscreen view instead displaying the pipeline Feb 26, 2020
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we so need a router

@odeimaiz odeimaiz merged commit 38f9c66 into ITISFoundation:master Mar 12, 2020
@odeimaiz odeimaiz deleted the feature/open-one-node branch March 12, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open node automatically
4 participants