Skip to content

maintenance: refactor CI scripts and simplify github CI workflows #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Mar 4, 2020
Merged

maintenance: refactor CI scripts and simplify github CI workflows #1337

merged 35 commits into from
Mar 4, 2020

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • renamed bash scripts to .bash
  • shellcheck all CI scripts
  • fuse PR and push github workflow in 1 file

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg added this to the Mithos milestone Mar 3, 2020
@sanderegg sanderegg self-assigned this Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020 •
edited
Loading

Codecov Report

Merging #1337 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1337   +/-   ##
=======================================
  Coverage   72.64%   72.64%           
=======================================
  Files         201      201           
  Lines        8356     8356           
  Branches      938      938           
=======================================
  Hits         6070     6070           
  Misses       2013     2013           
  Partials      273      273
Flag Coverage Δ
#integrationtests 57.63% <0.00%> (ø)
#unittests 67.06% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0eb474...f0eb474. Read the comment docs.

@sanderegg sanderegg force-pushed the fix_github_actions branch from 88fa3f6 to 607a571 Compare March 3, 2020 09:12
@sanderegg sanderegg requested review from pcrespov and mguidon and removed request for pcrespov and mguidon March 3, 2020 13:36
@sanderegg sanderegg requested review from pcrespov and mguidon March 3, 2020 13:41
pcrespov
pcrespov approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it

@sanderegg sanderegg requested a review from odeimaiz March 4, 2020 06:38
@sanderegg sanderegg merged commit fe965c3 into ITISFoundation:master Mar 4, 2020
@sanderegg sanderegg deleted the fix_github_actions branch March 4, 2020 07:14
@sanderegg sanderegg mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@mguidon mguidon Awaiting requested review from mguidon

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

Assignees

@sanderegg sanderegg

Labels
None yet
Projects
None yet
Milestone
Mithos
Development

Successfully merging this pull request may close these issues.
2 participants
@sanderegg @pcrespov