Skip to content

e2e: Check number of output files #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 4, 2020

What do these changes do?

Puppeteer checks number of output files produced by a node.

So far we were only checking if some output was produced. Now we can check a specific number of outputs.

P.S. Since the node's logs file was hiding the lack of other outputs, this PR will make master red again.

Related issue number

closes #1341

@odeimaiz odeimaiz requested a review from sanderegg March 4, 2020 14:34
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #1343 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
- Coverage   72.73%   72.65%   -0.09%     
==========================================
  Files         201      201              
  Lines        8356     8356              
  Branches      938      938              
==========================================
- Hits         6078     6071       -7     
- Misses       2005     2012       +7     
  Partials      273      273
Flag Coverage Δ
#integrationtests 57.63% <ø> (-0.21%) ⬇️
#unittests 67.07% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/storage_api.py 35.29% <0%> (-23.53%) ⬇️
...rc/simcore_service_director/registry_cache_task.py 97.43% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce1b6b...5b9a247. Read the comment docs.

@odeimaiz odeimaiz changed the title check number of files in output e2e: Check number of output files Mar 4, 2020
@odeimaiz odeimaiz self-assigned this Mar 4, 2020
@odeimaiz odeimaiz requested review from ignapas and pcrespov March 4, 2020 14:39
@odeimaiz odeimaiz merged commit 118e87b into ITISFoundation:master Mar 4, 2020
@odeimaiz odeimaiz deleted the feature/e2e_expect_files branch March 4, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapt pupetteer scripts since sidecar now uploads logs to S3 as well
3 participants