Skip to content

Bugfix: Travis is still the one releasing to production #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

What do these changes do?

bugfix:

  • prevents github action from pushing :latest images.

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg added this to the Mithos milestone Mar 6, 2020
@sanderegg sanderegg self-assigned this Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1351 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   72.73%   72.72%   -0.02%     
==========================================
  Files         201      201              
  Lines        8358     8358              
  Branches      939      939              
==========================================
- Hits         6079     6078       -1     
- Misses       2005     2006       +1     
  Partials      274      274
Flag Coverage Δ
#integrationtests 57.82% <ø> (ø) ⬆️
#unittests 67.04% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 66.75% <0%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb5d1f...dbfc667. Read the comment docs.

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be good to make sure that images with the same tags are not overwritten. There are some scripts with that idea in our ITISFOujdation/Dockerfile repo!

@sanderegg sanderegg merged commit a056bd2 into ITISFoundation:master Mar 9, 2020
@sanderegg sanderegg deleted the bugfix/disable_github_action_release branch March 9, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants