-
Notifications
You must be signed in to change notification settings - Fork 30
[bugfix] ujson missing dependency in director service #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2c89c5a
Fixes ujson missing dependency
a4742b9
Adds shell access for manual testing
85dd0de
WIP: Creating tests for ujson
e1dd36b
Adds minimal testing to avoid ujson to fail again
8342104
Moved docker test to system
5c0146d
Refactor test_service_images
ba23a37
Refined test_ujson_installation
2d6b961
Shall trigger CI again ...
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# | ||
# Tests instalation issues related to ujson inside or outside the container | ||
# https://github.com/kohlschutter/junixsocket/issues/33 | ||
# | ||
import subprocess | ||
import sys | ||
import os | ||
from pathlib import Path | ||
|
||
current_dir = Path(sys.argv[0] if __name__ == "__main__" else __file__).resolve().parent | ||
|
||
|
||
def test_ujson_installation(): | ||
# pylint: disable=c-extension-no-member | ||
import ujson | ||
|
||
assert ujson.__version__ | ||
|
||
with open(current_dir / "fixtures/dummy_service_description-v1.json") as fh: | ||
obj = ujson.load(fh) | ||
assert ujson.loads(ujson.dumps(obj)) == obj | ||
|
||
|
||
def test_docker_installation(): | ||
registry = os.environ.get("DOCKER_REGISTRY", "local") | ||
tag = os.environ.get("DOCKER_IMAGE_TAG", "production") | ||
|
||
assert subprocess.run( | ||
f'docker run -t --rm {registry}/director:{tag} python -c "import ujson; print(ujson.__version__)"', | ||
shell=True, | ||
check=True, | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.