Skip to content

[bugfix] ujson missing dependency in director service #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 9, 2020
Merged

[bugfix] ujson missing dependency in director service #1353

merged 8 commits into from
Mar 9, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 9, 2020 •
edited
Loading

What do these changes do?

  • fixes ujson missing dependency
  • adds target to access shell

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Mar 9, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a056bd2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1353   +/-   ##
=========================================
  Coverage          ?   72.63%           
=========================================
  Files             ?      201           
  Lines             ?     8358           
  Branches          ?      939           
=========================================
  Hits              ?     6071           
  Misses            ?     2013           
  Partials          ?      274
Flag Coverage Δ
#integrationtests 57.61% <ø> (?)
#unittests 67.06% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a056bd2...2d6b961. Read the comment docs.

odeimaiz
odeimaiz approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a test that pops up these kind of errors?

@pcrespov pcrespov marked this pull request as ready for review March 9, 2020 12:53
@pcrespov pcrespov requested review from sanderegg and mguidon March 9, 2020 12:54
mguidon
mguidon approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Go ahead.

@pcrespov pcrespov mentioned this pull request Mar 9, 2020
Merged
@pcrespov pcrespov merged commit ac51c73 into ITISFoundation:master Mar 9, 2020
@pcrespov pcrespov deleted the fix/director-ujson branch March 9, 2020 15:34
@sanderegg sanderegg mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguidon mguidon mguidon approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcrespov @odeimaiz @mguidon