Skip to content

[maintenance] missing sync openapi, upgrades pip #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 9, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 9, 2020

What do these changes do?

  • fixes missing sync with openapi specs
  • upgrades pip from 19 to 20
  • Adds update alpine package management (apk) and systematically installs basic libraries

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

Pedro Crespo added 3 commits March 9, 2020 13:56
Adds apk update in all dockers and basic client libs
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #1354 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1354      +/-   ##
=========================================
+ Coverage   72.69%   72.7%   +0.01%     
=========================================
  Files         201     201              
  Lines        8356    8356              
  Branches      937     937              
=========================================
+ Hits         6074    6075       +1     
+ Misses       2011    2010       -1     
  Partials      271     271
Flag Coverage Δ
#integrationtests 57.55% <ø> (ø) ⬆️
#unittests 67.12% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 67.01% <0%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4410e6...6804be1. Read the comment docs.

@pcrespov pcrespov self-assigned this Mar 9, 2020
@pcrespov pcrespov changed the title WIP: Maintenace/march9 [maintenance] missing sync openapi, upgrades pip Mar 9, 2020
@pcrespov pcrespov requested review from sanderegg and mguidon and removed request for sanderegg March 9, 2020 15:45
@pcrespov pcrespov marked this pull request as ready for review March 9, 2020 15:45
@pcrespov pcrespov merged commit 2ad810c into ITISFoundation:master Mar 9, 2020
@pcrespov pcrespov deleted the maintenace/march9 branch March 9, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant