Skip to content

fixes script to migrate comp_tasks table #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • original table was not dropped after migration
    -> was creating issue when deleting projects as the table constrained were still used.

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg requested review from pcrespov and mguidon March 11, 2020 07:44
@sanderegg sanderegg self-assigned this Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6a29b43). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1357   +/-   ##
=========================================
  Coverage          ?   72.84%           
=========================================
  Files             ?      201           
  Lines             ?     8356           
  Branches          ?      937           
=========================================
  Hits              ?     6087           
  Misses            ?     1997           
  Partials          ?      272
Flag Coverage Δ
#integrationtests 57.75% <ø> (?)
#unittests 67.17% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a29b43...2b83ad1. Read the comment docs.

@sanderegg sanderegg requested a review from odeimaiz March 11, 2020 09:17
@sanderegg sanderegg merged commit c700f28 into ITISFoundation:master Mar 11, 2020
@sanderegg sanderegg deleted the bugfix/drop_of_original_table_failed_as_sequence_was_still_attached branch March 11, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants