[enhancement] Check task exists in db and requirements upgrade #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
+ Coverage 72.61% 72.63% +0.01%
==========================================
Files 201 201
Lines 8414 8426 +12
Branches 943 945 +2
==========================================
+ Hits 6110 6120 +10
+ Misses 2030 2029 -1
- Partials 274 277 +3
Continue to review full report at Codecov.
|
added 5 commits
March 11, 2020 14:02
Previous logic would fill the postgres service log with errors. This solution is more quite Created subfunctions to separate logic
pcrespov
force-pushed
the
enh/check-task-exists-in-db
branch
from
5c06420 to
a223728
Compare
pcrespov
changed the title
sanderegg
approved these changes
Mar 11, 2020
services/web/server/src/simcore_service_webserver/computation_api.py
Outdated
Show resolved
Hide resolved
pcrespov
changed the title
odeimaiz
approved these changes
Mar 12, 2020
mguidon
approved these changes
Mar 12, 2020
added 2 commits
March 12, 2020 10:21
…arc-simcore into enh/check-task-exists-in-db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Due to a "race condition fix" done for the comp-tasks table, we introduced a additional constraint in the db table. This constraint was also "abused" to check whether a task was already in place or not. At the time this seemed to me an efficient way of "check and if it does not exists, create" in one call. The drawback is that it would log lots of irrelevant error messages in the postgres server. This type of noise was hiding real issues.
Now instead, we split in two calls: pre-check task existence before creating in comp-tasks table. It adds one call but the errors are only logged when we have race condition. No
some minor extras
sc-pg discoverand added Makefile recipe for devHow to test
Run a tutorial. Tasks should be correctly updated in comp-task table
Checklist
make openapi-specs,git commit ...and thenmake version-*)