Skip to content

Bump alembic from 1.0.8 to 1.4.1 in /packages/postgres-database #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Mar 16, 2020

Bumps alembic from 1.0.8 to 1.4.1.

Release notes

Sourced from alembic's releases.

1.4.1

Released: March 1, 2020

bug

  • [bug] [autogenerate] Fixed regression caused by the new "type comparison" logic introduced in 1.4 as part of #605 where comparisons of MySQL "unsigned integer" datatypes would produce false positives, as the regular expression logic was not correctly parsing the "unsigned" token when MySQL's default display width would be returned by the database. Pull request courtesy Paul Becotte.

    References: #661

  • [bug] [environment] Error message for "path doesn't exist" when loading up script environment now displays the absolute path. Pull request courtesy Rowan Hart.

    References: #663

  • [bug] [autogenerate] Fixed regression in 1.4.0 due to #647 where unique constraint comparison with mixed case constraint names while not using a naming convention would produce false positives during autogenerate.

    References: #654

  • [bug] [environment] The check for matched rowcount when the alembic_version table is updated or deleted from is now conditional based on whether or not the dialect supports the concept of "rowcount" for UPDATE or DELETE rows matched. Some third party dialects do not support this concept. Pull request courtesy Ke Zhu.

  • [bug] [operations] Fixed long-standing bug where an inline column CHECK constraint would not be rendered within an "ADD COLUMN" operation. The DDL compiler is now consulted for inline constraints within the Operations.add_column() method as is done for regular CREATE TABLE operations.

    References: #655

1.4.0

Released: February 4, 2020

feature

  • [feature] [batch] Added new parameters BatchOperations.add_column.insert_before, BatchOperations.add_column.insert_after which provide for establishing the specific position in which a new column should be placed.
... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @pcrespov.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d94fba2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1385   +/-   ##
=========================================
  Coverage          ?   66.76%           
=========================================
  Files             ?      201           
  Lines             ?     8437           
  Branches          ?      947           
=========================================
  Hits              ?     5633           
  Misses            ?     2575           
  Partials          ?      229
Flag Coverage Δ
#unittests 66.76% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94fba2...76e5ad9. Read the comment docs.

@pcrespov pcrespov requested review from pcrespov and sanderegg March 16, 2020 09:03
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning, this needs some checks with the CLI. Shall add some extra tests?

@pcrespov pcrespov self-assigned this Mar 16, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/pip/packages/postgres-database/alembic-1.4.1 branch from 82554fc to 27fd731 Compare March 16, 2020 09:11
@pcrespov pcrespov closed this Mar 16, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@pcrespov pcrespov deleted the dependabot/pip/packages/postgres-database/alembic-1.4.1 branch March 16, 2020 11:04
@pcrespov pcrespov restored the dependabot/pip/packages/postgres-database/alembic-1.4.1 branch March 16, 2020 11:06
@pcrespov pcrespov reopened this Mar 16, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/pip/packages/postgres-database/alembic-1.4.1 branch from 27fd731 to 875156b Compare March 16, 2020 11:08
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried migration CLI offline and works with this version

@dependabot-preview dependabot-preview bot force-pushed the dependabot/pip/packages/postgres-database/alembic-1.4.1 branch from 875156b to 76e5ad9 Compare March 16, 2020 12:19
@pcrespov pcrespov merged commit ef492bd into master Mar 16, 2020
@pcrespov pcrespov deleted the dependabot/pip/packages/postgres-database/alembic-1.4.1 branch March 16, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant