Skip to content

[bugfix] webserver cannot reach catalog in master deploy #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 16, 2020

What do these changes do?

Fixes url resolution and solves issues in master environ:

Traceback (most recent call last):,
  File "/usr/local/lib/python3.6/site-packages/servicelib/rest_middlewares.py", line 62, in _middleware,
    response = await handler(request),
  File "/usr/local/lib/python3.6/site-packages/servicelib/rest_middlewares.py", line 156, in _middleware,
    resp = await handler(request),
  File "/usr/local/lib/python3.6/site-packages/simcore_service_webserver/login/decorators.py", line 43, in wrapped,
    ret = await handler(*args, **kwargs),
  File "/usr/local/lib/python3.6/site-packages/simcore_service_webserver/catalog.py", line 77, in _reverse_proxy_handler,
    request.method, backend_url, headers=request.headers, data=raw,
  File "/usr/local/lib/python3.6/site-packages/aiohttp/client.py", line 1012, in __aenter__,
    self._resp = await self._coro,
  File "/usr/local/lib/python3.6/site-packages/aiohttp/client.py", line 483, in _request,
    timeout=real_timeout,
  File "/usr/local/lib/python3.6/site-packages/aiohttp/connector.py", line 523, in connect,
    proto = await self._create_connection(req, traces, timeout),
  File "/usr/local/lib/python3.6/site-packages/aiohttp/connector.py", line 859, in _create_connection,
    req, traces, timeout),
  File "/usr/local/lib/python3.6/site-packages/aiohttp/connector.py", line 971, in _create_direct_connection,
    raise ClientConnectorError(req.connection_key, exc) from exc,
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host catalog:8000 ssl:default [Name does not resolve],
WARNING:aiodebug.log_slow_callbacks:Executing <Handle <TaskWakeupMethWrapper object at 0x7fcbb106fa38>(<Task finishe...> result=None>)> took 0.105 seconds,
  • Modified setup environs to pass correct service name with appropriate prefix

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #1389 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1389      +/-   ##
==========================================
- Coverage   72.56%   72.49%   -0.08%     
==========================================
  Files         201      201              
  Lines        8437     8437              
  Branches      947      947              
==========================================
- Hits         6122     6116       -6     
- Misses       2037     2044       +7     
+ Partials      278      277       -1
Flag Coverage Δ
#integrationtests 57.37% <ø> (-0.21%) ⬇️
#unittests 66.72% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/storage_api.py 35.29% <0%> (-23.53%) ⬇️
.../director/src/simcore_service_director/producer.py 67.53% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5932f7f...345c7cb. Read the comment docs.

@pcrespov pcrespov merged commit 560798a into ITISFoundation:master Mar 16, 2020
@pcrespov pcrespov deleted the fix/webserver-catalog-link branch March 16, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants