Skip to content

Study Browser cleanup #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 83 commits into from
Mar 24, 2020
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 17, 2020

What do these changes do?

Dashboard Cleanup

  • Move main section selectors (buttons) (Dashboard, Services, Data) to top.
  • Remove detail view shown when clicking on a study sheet.
  • Activate study on single click
  • Move section for templates to top, add new study (use “Empty Study” as label) as normal sheet to front. Use “Create New Study” as title. Move section for existing studies to bottom, use “Recent Studies” as title.
  • Center studies in window. Show no more than 5 sheets in one row.

Cleanup of Study Sheets

  • Move all text to either top or bottom, but not both. Make use of default fonts.
  • Remove "Created by" field for user study sheets.
  • Remove “Last change” field for template study sheets.
  • Remove “Last change” and "Created by" in front of the actual last change time.
  • Add description field for template studies with small text below title.
  • Add poop-up-button on right side of title which offers basic commands such as Open, Remove, Rename, Clone, …

Bonus

  • Routes to statics are always set (thanks to @pcrespov)

Related issue number

related to ITISFoundation/osparc-issues#163
related to ITISFoundation/osparc-issues#164

Dashboard

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@odeimaiz odeimaiz self-assigned this Mar 17, 2020
@odeimaiz odeimaiz changed the title Feature/new study sheet WIP: Dashboard Cleanup Mar 17, 2020
@odeimaiz odeimaiz added this to the Dim Sum milestone Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1393 into master will increase coverage by 0.03%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   70.48%   70.51%   +0.03%     
==========================================
  Files         222      222              
  Lines        8811     8818       +7     
  Branches      967      968       +1     
==========================================
+ Hits         6210     6218       +8     
+ Misses       2324     2322       -2     
- Partials      277      278       +1
Flag Coverage Δ
#integrationtests 57.24% <20%> (+0.02%) ⬆️
#unittests 65.02% <73.33%> (+0.03%) ⬆️
Impacted Files Coverage Δ
...eb/server/src/simcore_service_webserver/statics.py 83.01% <73.33%> (+4.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ecf8d6...72c8005. Read the comment docs.

@odeimaiz odeimaiz changed the title Dashboard Cleanup Study Browser cleanup Mar 20, 2020
@pcrespov
Copy link
Member

pcrespov commented Mar 20, 2020

@odeimaiz HOw can I distinguish templates from normal projects in the UI?

@odeimaiz
Copy link
Member Author

@odeimaiz HOw can I distinguish templates from normal projects in the UI?

Templates are the ones in the "New Studies" section, where you can start from scratch or using a template

@pcrespov
Copy link
Member

@odeimaiz I will have a look at the issue with the webserver

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty 👍
very nice and go for it!

Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.
While testing I came up with some improvements, I will try to add them later on...
Only this is happening:
errorbrowse

@odeimaiz odeimaiz requested a review from ignapas March 24, 2020 14:55
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Mar 24, 2020
@odeimaiz odeimaiz merged commit c29beaf into ITISFoundation:master Mar 24, 2020
@odeimaiz odeimaiz deleted the feature/new-study-sheet branch March 25, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants