Skip to content

[maintenance] pytest-simcore package #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Mar 23, 2020

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 18, 2020

What do these changes do?

  • moved webserver integration test fixtures to a common package for use in all micro-services/system testing
  • moved helper functions to fixture package
  • added a pytest --keep-docker-up option when running tests that does not bring down docker-swarm and registry for faster test development
  • creates pytest-simcore as a stand-alone python package with hooks to pytest
  • used in webserver
  • fix environs.osparc_simcore_root_dir
  • fix conflict with packages/pytest-fixtures/rabbit_service.py

Related issue number

Maintenance to support Platform Stability

How to test

cd packages/pytest-simcore
make install-dev
make tests

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg added this to the Dim Sum milestone Mar 18, 2020
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #1394 into master will decrease coverage by 0.46%.
The diff coverage is 10.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1394      +/-   ##
=========================================
- Coverage   70.96%   70.5%   -0.47%     
=========================================
  Files         217     222       +5     
  Lines        8766    8811      +45     
  Branches      967     967              
=========================================
- Hits         6221    6212       -9     
- Misses       2266    2323      +57     
+ Partials      279     276       -3
Flag Coverage Δ
#integrationtests 57.22% <100%> (-0.35%) ⬇️
#unittests 65% <10.71%> (-0.33%) ⬇️
Impacted Files Coverage Δ
...s/service-library/src/servicelib/rabbitmq_utils.py 0% <0%> (ø)
...ages/service-library/src/servicelib/minio_utils.py 0% <0%> (ø)
...ages/service-library/src/servicelib/redis_utils.py 0% <0%> (ø)
...ce-library/src/servicelib/simcore_service_utils.py 0% <0%> (ø)
...ges/service-library/src/servicelib/celery_utils.py 0% <0%> (ø)
...simcore_service_webserver/computation_subscribe.py 97.1% <100%> (-0.2%) ⬇️
...erver/src/simcore_service_webserver/storage_api.py 35.29% <0%> (-23.53%) ⬇️
...simcore_service_webserver/director/director_api.py 51.66% <0%> (-3.34%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833f208...0b416ec. Read the comment docs.

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Mar 20, 2020
@pcrespov pcrespov changed the title WIP: Is/test fixtures WIP: [maintenance] pytest-simcore package Mar 20, 2020
@pcrespov pcrespov changed the title WIP: [maintenance] pytest-simcore package [maintenance] pytest-simcore package Mar 20, 2020
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up. Go ahead.

@pcrespov pcrespov merged commit 4ecf8d6 into ITISFoundation:master Mar 23, 2020
@sanderegg sanderegg deleted the is/test_fixtures branch March 31, 2020 21:18
@sanderegg sanderegg linked an issue Apr 6, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

platform stability
3 participants