Skip to content

Maintenance/upgrade trafaret 2 #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 26, 2020

What do these changes do?

trafaret upgrade to 2.0.x changes in the API demanded some minor refactoring

NOTE: This is a split of PR #1401

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov added dependencies t:maintenance Some planned maintenance work labels Mar 26, 2020
@pcrespov pcrespov self-assigned this Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #1409 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
- Coverage   70.76%   70.72%   -0.04%     
==========================================
  Files         225      225              
  Lines        8913     8916       +3     
  Branches      979      979              
==========================================
- Hits         6307     6306       -1     
- Misses       2324     2327       +3     
- Partials      282      283       +1
Flag Coverage Δ
#integrationtests 57.17% <100%> (ø) ⬆️
#unittests 65.29% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/simcore-sdk/src/simcore_sdk/config/s3.py 0% <ø> (ø) ⬆️
...r/src/simcore_service_webserver/activity/config.py 100% <ø> (ø) ⬆️
...rver/src/simcore_service_webserver/login/config.py 100% <ø> (ø) ⬆️
.../server/src/simcore_service_webserver/db_config.py 100% <ø> (ø) ⬆️
...rver/src/simcore_service_webserver/email_config.py 100% <ø> (ø) ⬆️
...r/src/simcore_service_webserver/socketio/config.py 92.3% <ø> (ø) ⬆️
...kages/simcore-sdk/src/simcore_sdk/config/rabbit.py 0% <ø> (ø) ⬆️
...r/src/simcore_service_webserver/director/config.py 100% <ø> (ø) ⬆️
...er/src/simcore_service_webserver/catalog_config.py 91.66% <ø> (ø) ⬆️
packages/service-library/src/servicelib/tracing.py 0% <ø> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83eb8fa...afcc69b. Read the comment docs.

@pcrespov pcrespov requested review from sanderegg and mguidon March 26, 2020 13:24
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful!

@pcrespov pcrespov merged commit aa945b2 into ITISFoundation:master Mar 27, 2020
@pcrespov pcrespov deleted the maintenance/upgrade-trafaret-2 branch March 27, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants