Skip to content

Fixes on webserver diagnostics submodule and setup in dev-mode #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 3, 2020

Fixes issues in master.
See commits

pcrespov added 3 commits April 3, 2020 13:16
During startup,
os.makedirs would fail to create /devel/services/web/client/resources
This has an effect only in devel  mode
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #1430 into master will decrease coverage by 10.99%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1430     +/-   ##
=========================================
- Coverage   71.43%   60.43%    -11%     
=========================================
  Files         240      240             
  Lines        9512     9512             
  Branches     1044     1045      +1     
=========================================
- Hits         6795     5749   -1046     
- Misses       2413     3487   +1074     
+ Partials      304      276     -28
Flag Coverage Δ
#integrationtests 58.53% <0%> (ø) ⬆️
#unittests 59% <ø> (-4.69%) ⬇️
Impacted Files Coverage Δ
...imcore_service_webserver/diagnostics_monitoring.py 29.5% <0%> (-63.94%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0% <0%> (-91.18%) ⬇️
...er/src/simcore_service_webserver/storage_routes.py 20% <0%> (-80%) ⬇️
...er/src/simcore_service_webserver/users_handlers.py 29.03% <0%> (-70.97%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 22.39% <0%> (-65.11%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 24.46% <0%> (-63.83%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 26.08% <0%> (-63.77%) ⬇️
...mcore_service_webserver/projects/projects_utils.py 14.81% <0%> (-62.97%) ⬇️
...rc/simcore_service_webserver/diagnostics_plugin.py 45.16% <0%> (-54.84%) ⬇️
...ver/src/simcore_service_webserver/rest_handlers.py 48% <0%> (-52%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a957016...0ae28d6. Read the comment docs.

@pcrespov pcrespov marked this pull request as ready for review April 3, 2020 15:40
@pcrespov pcrespov changed the title WIP: Maintenance 0304 Fixes on webserver diagnostics submodule and setup in dev-mode Apr 3, 2020
@pcrespov pcrespov requested review from mguidon, odeimaiz and sanderegg and removed request for odeimaiz and mguidon April 3, 2020 15:41
@pcrespov pcrespov self-assigned this Apr 3, 2020
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair reviewed

@pcrespov pcrespov merged commit bfdefc9 into ITISFoundation:master Apr 3, 2020
@pcrespov pcrespov deleted the maintenance-0304 branch April 3, 2020 16:31
@sanderegg sanderegg linked an issue Apr 6, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

platform stability
2 participants