Skip to content

Maintenance/minio endpoint and qooxdoo compiler logs #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • sets the devel S3_STORAGE_ENDPOINT to use the docker0 network interface -> it is now possible to use the storage from the frontend in local mode with this trick
  • when starting in devel mode with make up-devel now also follow the logs of the qooxdoo-kit container as before

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg self-assigned this Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1442 into master will decrease coverage by 6.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
- Coverage   71.61%   65.56%   -6.06%     
==========================================
  Files         241      241              
  Lines        9562     9562              
  Branches     1053     1053              
==========================================
- Hits         6848     6269     -579     
- Misses       2410     3029     +619     
+ Partials      304      264      -40     
Flag Coverage Δ
#integrationtests 54.22% <ø> (-4.63%) ⬇️
#unittests 63.35% <ø> (ø)
Impacted Files Coverage Δ
...ices/sidecar/src/simcore_service_sidecar/config.py 0.00% <0.00%> (-100.00%) ⬇️
services/sidecar/src/simcore_service_sidecar/db.py 0.00% <0.00%> (-92.00%) ⬇️
...vices/sidecar/src/simcore_service_sidecar/utils.py 0.00% <0.00%> (-87.18%) ⬇️
...rvices/sidecar/src/simcore_service_sidecar/core.py 0.00% <0.00%> (-85.72%) ⬇️
...es/sidecar/src/simcore_service_sidecar/executor.py 0.00% <0.00%> (-84.79%) ⬇️
...ervices/sidecar/src/simcore_service_sidecar/cli.py 0.00% <0.00%> (-75.00%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 24.61% <0.00%> (-56.93%) ⬇️
...core-sdk/src/simcore_sdk/node_ports/filemanager.py 22.22% <0.00%> (-54.77%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/dbmanager.py 38.33% <0.00%> (-48.34%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/nodeports.py 27.77% <0.00%> (-47.78%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb65bab...b2b9848. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor here

@sanderegg sanderegg requested a review from pcrespov April 7, 2020 08:57
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super! :-)

Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@sanderegg sanderegg merged commit c187cd4 into ITISFoundation:master Apr 7, 2020
@sanderegg sanderegg deleted the maintenance/minio_qooxdoo branch April 7, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants