Skip to content

fix env already shows published port #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

sanderegg
Copy link
Member

What do these changes do?

fix: minio fixture trying to find the published port when it is already the published port

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg self-assigned this Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1443 into master will increase coverage by 6.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
+ Coverage   65.56%   71.61%   +6.05%     
==========================================
  Files         241      241              
  Lines        9562     9562              
  Branches     1053     1053              
==========================================
+ Hits         6269     6848     +579     
+ Misses       3028     2410     -618     
- Partials      265      304      +39     
Flag Coverage Δ
#integrationtests 58.85% <ø> (+4.62%) ⬆️
#unittests 63.35% <ø> (ø)
Impacted Files Coverage Δ
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 92.06% <0.00%> (+3.17%) ⬆️
...core-sdk/src/simcore_sdk/node_ports/_items_list.py 90.69% <0.00%> (+4.65%) ⬆️
...sdk/src/simcore_sdk/node_ports/_data_items_list.py 63.15% <0.00%> (+7.89%) ⬆️
...k/src/simcore_sdk/node_ports/_schema_items_list.py 100.00% <0.00%> (+8.69%) ⬆️
.../sidecar/src/simcore_service_sidecar/log_parser.py 91.37% <0.00%> (+12.06%) ⬆️
...core-sdk/src/simcore_sdk/models/pipeline_models.py 63.63% <0.00%> (+12.12%) ⬆️
...mcore-sdk/src/simcore_sdk/node_ports/exceptions.py 72.72% <0.00%> (+13.63%) ⬆️
...sdk/src/simcore_sdk/node_ports/data_items_utils.py 100.00% <0.00%> (+37.50%) ⬆️
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 93.51% <0.00%> (+42.59%) ⬆️
...imcore-sdk/src/simcore_sdk/node_ports/nodeports.py 75.55% <0.00%> (+47.77%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c187cd4...e218eef. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on fire!

@sanderegg sanderegg merged commit 0aa3fd3 into ITISFoundation:master Apr 7, 2020
@sanderegg sanderegg deleted the bugfix/minio_fixture branch April 7, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants