Skip to content

[Maintenance] package reqs update and extended invitation lifetime #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 4, 2020

What do these changes do?

Weekly dependency updates

  • upgrades packages reqs in all packages and webserver service : pytz 2020.1, tenacity 6.2.0,
  • pylint 2.5.2 STILL FAILS ! Reverted to 2.5.0
  • sync CI pylint with packages/service-library/requirements/_test.txt
  • Minor makefile fixes:
    • Badge to coveralls
    • make requirements now comments dependencies from requirements folder as dependabot does.
    • NEW make autodoc to produce graph from docker-compose config .stack-simcore-version.yml
  • Updates default expiration for invitation to 15 days (requested by @KZzizzle )

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label May 4, 2020
@pcrespov pcrespov self-assigned this May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #1482 into master will decrease coverage by 18.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1482       +/-   ##
===========================================
- Coverage   71.47%   52.55%   -18.92%     
===========================================
  Files         244       32      -212     
  Lines        9706      666     -9040     
  Branches     1060       33     -1027     
===========================================
- Hits         6937      350     -6587     
+ Misses       2464      310     -2154     
+ Partials      305        6      -299     
Flag Coverage Δ
#integrationtests ?
#unittests ?
Impacted Files Coverage Δ
...ar/src/simcore_service_sidecar/celery_log_setup.py
...es/storage/src/simcore_service_storage/__main__.py
...ges/service-library/src/servicelib/request_keys.py
...ervice_webserver/reverse_proxy/handlers/jupyter.py
...rver/src/simcore_service_webserver/login/routes.py
...ore_service_webserver/resource_manager/registry.py
...rvices/sidecar/src/simcore_service_sidecar/core.py
...core-sdk/src/simcore_sdk/node_data/data_manager.py
...ages/service-library/src/servicelib/rest_codecs.py
...es/director/src/simcore_service_director/config.py
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0672cf0...6e9710a. Read the comment docs.

@pcrespov pcrespov changed the title Maintenance/package reqs update [Maintenance] package reqs update May 4, 2020
@pcrespov pcrespov marked this pull request as ready for review May 4, 2020 18:17
@pcrespov pcrespov requested review from sanderegg, GitHK and KZzizzle May 4, 2020 18:18
@pcrespov pcrespov changed the title [Maintenance] package reqs update [Maintenance] package reqs update and extended invitation lifetime May 4, 2020
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the pylint requirements to not include 2.5.0. it fails as soon as more than 1 job is used to lint see comment for the link.

added codecov and removed deprecated links
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about requirements but the longer validity duration of invitation links is nice!

@pcrespov pcrespov requested a review from sanderegg May 5, 2020 10:13
@pcrespov pcrespov mentioned this pull request May 5, 2020
11 tasks
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency updates should not have any effects to Redis codebase.

lastest 2.5.3 failes to run in parallel
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #1482 into master will decrease coverage by 18.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1482       +/-   ##
===========================================
- Coverage   71.47%   52.55%   -18.92%     
===========================================
  Files         244       32      -212     
  Lines        9706      666     -9040     
  Branches     1060       33     -1027     
===========================================
- Hits         6937      350     -6587     
+ Misses       2464      310     -2154     
+ Partials      305        6      -299     
Flag Coverage Δ
#integrationtests ?
#unittests ?
Impacted Files Coverage Δ
...kages/service-library/src/servicelib/rest_utils.py
packages/simcore-sdk/src/simcore_sdk/config/db.py
...imcore_service_webserver/security_authorization.py
...es/storage/src/simcore_service_storage/__main__.py
.../simcore_service_webserver/security_permissions.py
...core_service_webserver/projects/projects_models.py
...sdk/src/simcore_sdk/node_ports/data_items_utils.py
...eb/server/src/simcore_service_webserver/catalog.py
...eb/server/src/simcore_service_webserver/storage.py
...rc/simcore_service_webserver/computation_models.py
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0672cf0...6e9710a. Read the comment docs.

@pcrespov pcrespov merged commit 1f14e0a into ITISFoundation:master May 5, 2020
@pcrespov pcrespov deleted the maintenance/package-reqs-update branch May 5, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants