Skip to content

Fix Postgres migration #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 12, 2020
Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented May 11, 2020

What do these changes do?

  • Fix an issue where forked projects with different names would not get upgraded.
  • Fix some permission issues.
  • make postgres-upgrade now prints the containers logs on exit (helps with debugging).

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@GitHK GitHK changed the title Fix postres migration Fix Postgres migration May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #1495 into master will decrease coverage by 18.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1495       +/-   ##
===========================================
- Coverage   71.30%   52.55%   -18.76%     
===========================================
  Files         247       32      -215     
  Lines        9957      666     -9291     
  Branches     1094       33     -1061     
===========================================
- Hits         7100      350     -6750     
+ Misses       2545      310     -2235     
+ Partials      312        6      -306     
Flag Coverage Δ
#integrationtests ?
#unittests ?
Impacted Files Coverage Δ
...es/storage/src/simcore_service_storage/__init__.py
...irector/src/simcore_service_director/exceptions.py
...ce-library/src/servicelib/jsonschema_validation.py
...simcore_service_webserver/projects/projects_api.py
...core-sdk/src/simcore_sdk/node_data/data_manager.py
...er/src/simcore_service_webserver/security_roles.py
...s/storage/src/simcore_service_storage/resources.py
...b/server/src/simcore_service_webserver/__main__.py
...ices/storage/src/simcore_service_storage/models.py
...rvices/sidecar/src/simcore_service_sidecar/core.py
... and 205 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17643ba...af266a7. Read the comment docs.

@GitHK GitHK self-assigned this May 11, 2020
@GitHK GitHK added the bug buggy, it does not work as expected label May 11, 2020
@GitHK GitHK requested review from odeimaiz, sanderegg and pcrespov May 11, 2020 07:58
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK merged commit 8866918 into ITISFoundation:master May 12, 2020
@GitHK GitHK deleted the fix-postres-migration branch May 25, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants