director: renew cache in the background instead of clearing cache #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1496 +/- ##
==========================================
- Coverage 71.24% 71.16% -0.08%
==========================================
Files 247 139 -108
Lines 9959 5189 -4770
Branches 1094 501 -593
==========================================
- Hits 7095 3693 -3402
+ Misses 2550 1382 -1168
+ Partials 314 114 -200
Continue to review full report at Codecov.
|
odeimaiz
approved these changes
May 12, 2020
pcrespov
approved these changes
May 12, 2020
| @@ -46,7 +47,7 @@ async def test_registry_caching_task(loop, client, push_services): | |||
| number_of_computational_services=1, number_of_interactive_services=1 | |||
| ) | |||
| # the services shall be updated | |||
| await sleep(config.DIRECTOR_REGISTRY_CACHING_TTL) | |||
| await sleep(config.DIRECTOR_REGISTRY_CACHING_TTL * 1.1) # NOTE: this can take some time. Sleep increased by 10%. | |||
There was a problem hiding this comment.
MINOR: why not simply increasing the variable itself? Is it used somewhere else?
There was a problem hiding this comment.
yes it is used by the director registry caching task. the point is to wait longer than him. probably the very right way would be to find the task out and wait for it.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Until now the director was caching calls to the registry by clearing the cache every 15 minutes.
Now the background task first gets the new cache and replaces it after success thus there is no time where there is no cache. Unless some error (registry not available) happens.
Related issue number
How to test
Checklist
make openapi-specs,git commit ...and thenmake version-*)