Skip to content

UI/UX: Dashboard Cleanup, Follow-Up I #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
May 14, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 11, 2020

What do these changes do?

  • Major aligned elements in Dashboard
  • "Dashboard" is only a button when you are in the Study Editor (also shows a "back" arrow), otherwise it's a label
  • Study sheet:
    • "Create New Study" -> "Empty Study"
    • Title text’s baseline aligned with the menu button
    • More padding
    • Longer vertically than horizontally.
    • File related icons: empty file (new from scratch), copy file (template), file with text (own study)

Before:
image

After:
image

Related issue number

ITISFoundation/osparc-issues#169

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #1497 into master will decrease coverage by 14.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1497       +/-   ##
===========================================
- Coverage   73.91%   59.23%   -14.68%     
===========================================
  Files         107      233      +126     
  Lines        4523     9688     +5165     
  Branches      468     1085      +617     
===========================================
+ Hits         3343     5739     +2396     
- Misses       1072     3671     +2599     
- Partials      108      278      +170     
Flag Coverage Δ
#integrationtests 58.00% <0.00%> (?)
#unittests 53.03% <0.00%> (-20.89%) ⬇️
Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/rest_models.py 0.00% <0.00%> (-91.18%) ⬇️
...er/src/simcore_service_webserver/storage_routes.py 20.00% <0.00%> (-80.00%) ⬇️
...er/src/simcore_service_webserver/users_handlers.py 28.03% <0.00%> (-68.23%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 22.39% <0.00%> (-65.11%) ⬇️
...mcore_service_webserver/projects/projects_utils.py 14.11% <0.00%> (-64.71%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 24.46% <0.00%> (-63.83%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 26.08% <0.00%> (-63.77%) ⬇️
...imcore_service_webserver/diagnostics_monitoring.py 29.50% <0.00%> (-62.30%) ⬇️
...mcore_service_webserver/login/api_keys_handlers.py 36.76% <0.00%> (-55.89%) ⬇️
...rc/simcore_service_webserver/diagnostics_plugin.py 45.16% <0.00%> (-54.84%) ⬇️
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620c3ff...620c3ff. Read the comment docs.

@odeimaiz odeimaiz self-assigned this May 11, 2020
@odeimaiz odeimaiz marked this pull request as ready for review May 13, 2020 11:55
@odeimaiz odeimaiz changed the title [WIP] UI/UX Some more UI/UX May 13, 2020
@odeimaiz odeimaiz changed the title Some more UI/UX UI/UX: Dashboard Cleanup, Follow-Up I May 13, 2020
@odeimaiz odeimaiz merged commit 8cfa371 into ITISFoundation:master May 14, 2020
@odeimaiz odeimaiz deleted the feature/ui-ux branch May 19, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants