Skip to content

[bug] Is479/cc stability #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 19, 2020
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 12, 2020

What do these changes do?

Fixes failure of CC Human e2e test.

image

  • Fixes update output nodes in project
  • Fixes upload-files with nodeports: nodeports is not concurrent-safe, cannot use asyncio.gather to update each output ports, i.e await output.set

Related issue number

How to test

Run [ISAN] CC human study

@pcrespov pcrespov self-assigned this May 12, 2020
@pcrespov pcrespov added the bug buggy, it does not work as expected label May 12, 2020
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #1500 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   71.27%   71.24%   -0.03%     
==========================================
  Files         247      247              
  Lines        9976     9977       +1     
  Branches     1097     1098       +1     
==========================================
- Hits         7110     7108       -2     
- Misses       2554     2556       +2     
- Partials      312      313       +1     
Flag Coverage Δ
#integrationtests 57.94% <33.33%> (-0.01%) ⬇️
#unittests 63.30% <14.81%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...es/sidecar/src/simcore_service_sidecar/__init__.py 100.00% <ø> (ø)
...sidecar/src/simcore_service_sidecar/__version__.py 100.00% <ø> (ø)
...ices/sidecar/src/simcore_service_sidecar/celery.py 0.00% <0.00%> (ø)
...ar/src/simcore_service_sidecar/celery_log_setup.py 0.00% <0.00%> (ø)
.../simcore_service_webserver/computation_handlers.py 87.75% <ø> (-0.25%) ⬇️
.../simcore_service_webserver/projects/projects_db.py 83.33% <0.00%> (ø)
...simcore_service_webserver/projects/projects_api.py 80.70% <18.75%> (-0.72%) ⬇️
...es/sidecar/src/simcore_service_sidecar/executor.py 85.41% <100.00%> (+0.07%) ⬆️
...s/web/server/src/simcore_service_webserver/rest.py 89.58% <100.00%> (ø)
.../director/src/simcore_service_director/producer.py 65.90% <0.00%> (-0.51%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b7ec2...bb88678. Read the comment docs.

@pcrespov pcrespov force-pushed the is479/cc-stability branch from e30dab8 to c1d0da7 Compare May 12, 2020 20:44
pcrespov added 9 commits May 19, 2020 11:18
- avoids /api/ which already routed by traffik
This entry is NOT replaced but updated at the level of "output-name".
The data of a give output is obviously replaced.
@pcrespov pcrespov force-pushed the is479/cc-stability branch from c1d0da7 to bcab39a Compare May 19, 2020 09:18
@pcrespov pcrespov requested review from sanderegg and odeimaiz May 19, 2020 09:43
@pcrespov pcrespov changed the title WIP: [bug] Is479/cc stability [bug] Is479/cc stability May 19, 2020
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to some green...

@sanderegg sanderegg marked this pull request as ready for review May 19, 2020 11:34
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm about to cry 💪

@pcrespov pcrespov merged commit e17c30b into ITISFoundation:master May 19, 2020
@pcrespov pcrespov deleted the is479/cc-stability branch May 19, 2020 12:13
@sanderegg sanderegg mentioned this pull request Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants