Skip to content

Fix opencor e2e test #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2020
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 13, 2020

What do these changes do?

The issue was not the opencor test itself, but this test is the first one that has to click on a NodesTree item. The problem is that some context checks are done when clicking an item and since the export button does not exist for GUEST users, the enable/disable operation on the button fails, not letting the item-clicking-routine go through.

@odeimaiz odeimaiz self-assigned this May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #1503 into master will increase coverage by 2.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
+ Coverage   71.28%   73.91%   +2.63%     
==========================================
  Files         247      107     -140     
  Lines        9969     4523    -5446     
  Branches     1096      468     -628     
==========================================
- Hits         7106     3343    -3763     
+ Misses       2550     1072    -1478     
+ Partials      313      108     -205     
Flag Coverage Δ
#integrationtests ?
#unittests 73.91% <ø> (+10.56%) ⬆️
Impacted Files Coverage Δ
...simcore_service_webserver/computation_subscribe.py 33.33% <0.00%> (-63.77%) ⬇️
.../simcore_service_webserver/computation_handlers.py 40.00% <0.00%> (-48.00%) ⬇️
...r/src/simcore_service_webserver/computation_api.py 18.98% <0.00%> (-46.21%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 30.15% <0.00%> (-41.27%) ⬇️
...simcore_service_webserver/director/director_api.py 25.00% <0.00%> (-26.67%) ⬇️
...erver/src/simcore_service_webserver/computation.py 63.63% <0.00%> (-22.73%) ⬇️
...rc/simcore_service_webserver/computation_models.py 55.55% <0.00%> (-22.23%) ⬇️
..._service_webserver/projects/projects_exceptions.py 54.54% <0.00%> (-18.19%) ⬇️
...r/src/simcore_service_webserver/director/config.py 86.66% <0.00%> (-13.34%) ⬇️
...simcore_service_webserver/projects/projects_api.py 74.33% <0.00%> (-7.08%) ⬇️
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3229e...ffc4b25. Read the comment docs.

@odeimaiz odeimaiz requested review from GitHK, pcrespov and sanderegg May 13, 2020 08:51
@odeimaiz odeimaiz merged commit 55efd02 into ITISFoundation:master May 14, 2020
@odeimaiz odeimaiz deleted the feature/fix-opencor-e2e branch May 14, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants