-
Notifications
You must be signed in to change notification settings - Fork 28
Fix opencor e2e test #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
odeimaiz
merged 4 commits into
ITISFoundation:master
from
odeimaiz:feature/fix-opencor-e2e
May 14, 2020
Merged
Fix opencor e2e test #1503
odeimaiz
merged 4 commits into
ITISFoundation:master
from
odeimaiz:feature/fix-opencor-e2e
May 14, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1503 +/- ##
==========================================
+ Coverage 71.28% 73.91% +2.63%
==========================================
Files 247 107 -140
Lines 9969 4523 -5446
Branches 1096 468 -628
==========================================
- Hits 7106 3343 -3763
+ Misses 2550 1072 -1478
+ Partials 313 108 -205
Continue to review full report at Codecov.
|
sanderegg
approved these changes
May 13, 2020
ignapas
approved these changes
May 13, 2020
pcrespov
approved these changes
May 13, 2020
GitHK
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The issue was not the opencor test itself, but this test is the first one that has to click on a NodesTree item. The problem is that some context checks are done when clicking an item and since the export button does not exist for GUEST users, the enable/disable operation on the button fails, not letting the item-clicking-routine go through.