-
Notifications
You must be signed in to change notification settings - Fork 28
Fix wrong redis key #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong redis key #1504
Conversation
avoids creating corrupted keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good go ahead
packages/pytest-simcore/src/pytest_simcore/helpers/utils_pylint.py
Outdated
Show resolved
Hide resolved
…-forked into fix-wrong-redis-key
AUTODETECT = 0 | ||
|
||
|
||
def assert_pylint_is_passing(pylintrc, package_dir, number_of_jobs: int = AUTODETECT): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MINOR: let's try to add types when it is clear. We are slowly adopting this among other things to user http://mypy-lang.org/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice additions! go ahead!
What do these changes do?
Related issue number
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)