Skip to content

Fix wrong redis key #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 15, 2020
Merged

Fix wrong redis key #1504

merged 19 commits into from
May 15, 2020

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented May 13, 2020

What do these changes do?

  • Fixes an issue where registry keys were created in a wrong manner
  • Improves Pylint testing run by pytest. It will now display some meaningful error upon fail
  • Refactors pylint testing utils, which now get imported from the common pytest-simcore library

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@GitHK GitHK added the bug buggy, it does not work as expected label May 13, 2020
@GitHK GitHK requested review from pcrespov and sanderegg May 13, 2020 15:14
@GitHK GitHK self-assigned this May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #1504 into master will decrease coverage by 18.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1504       +/-   ##
===========================================
- Coverage   71.28%   52.55%   -18.73%     
===========================================
  Files         247       32      -215     
  Lines        9969      666     -9303     
  Branches     1096       33     -1063     
===========================================
- Hits         7106      350     -6756     
+ Misses       2550      310     -2240     
+ Partials      313        6      -307     
Flag Coverage Δ
#integrationtests ?
#unittests ?
Impacted Files Coverage Δ
...rver/src/simcore_service_webserver/tag_handlers.py
...simcore_service_webserver/director/director_api.py
...rc/simcore_service_webserver/application_config.py
...er/src/simcore_service_webserver/login/handlers.py
...ges/service-library/src/servicelib/celery_utils.py
...s/web/server/src/simcore_service_webserver/rest.py
.../server/src/simcore_service_webserver/login/cfg.py
.../sidecar/src/simcore_service_sidecar/exceptions.py
.../web/server/src/simcore_service_webserver/email.py
...mcore_service_webserver/projects/nodes_handlers.py
... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55efd02...3650e62. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good go ahead

@GitHK GitHK marked this pull request as draft May 13, 2020 15:49
@GitHK GitHK changed the title Fix wrong redis key WIP: Fix wrong redis key May 13, 2020
@GitHK GitHK marked this pull request as ready for review May 14, 2020 09:45
@GitHK GitHK changed the title WIP: Fix wrong redis key Fix wrong redis key May 14, 2020
@GitHK GitHK requested review from pcrespov and sanderegg May 14, 2020 15:21
AUTODETECT = 0


def assert_pylint_is_passing(pylintrc, package_dir, number_of_jobs: int = AUTODETECT):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR: let's try to add types when it is clear. We are slowly adopting this among other things to user http://mypy-lang.org/

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice additions! go ahead!

@GitHK GitHK merged commit 35d4347 into ITISFoundation:master May 15, 2020
@GitHK GitHK deleted the fix-wrong-redis-key branch May 25, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants