Skip to content

Minor+Patch upgrades in python packages and system+api testing #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 20, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 19, 2020

What do these changes do?

  • Minor or Patch upgrades for libraries within python packages or system/api testing requirements:
    • sqlalchemy patch 1.3.17
    • multidict
    • packaging and more-itertools (for testing via pytest)
  • Enhance scripts/requirements/Makefile to automate this job
  • Prepares for pylint upgrade: cleanup of ignore rules in tests
  • Autoformat cleanup
  • Removes old deprectaed code web/server/tests/sandbox

@pcrespov pcrespov self-assigned this May 19, 2020
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #1513 into master will decrease coverage by 11.30%.
The diff coverage is 94.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1513       +/-   ##
===========================================
- Coverage   70.90%   59.60%   -11.31%     
===========================================
  Files         249      249               
  Lines       10097    10097               
  Branches     1114     1114               
===========================================
- Hits         7159     6018     -1141     
- Misses       2619     3788     +1169     
+ Partials      319      291       -28     
Flag Coverage Δ
#integrationtests 57.74% <ø> (ø)
#unittests 54.35% <94.44%> (-8.58%) ⬇️
Impacted Files Coverage Δ
...ices/director/src/simcore_service_director/main.py 85.18% <ø> (ø)
...rc/simcore_service_director/rest/node_validator.py 72.00% <0.00%> (ø)
...ector/src/simcore_service_director/system_utils.py 54.54% <ø> (ø)
...irector/src/simcore_service_director/exceptions.py 62.50% <66.66%> (ø)
...e-library/src/servicelib/monitor_slow_callbacks.py 100.00% <100.00%> (ø)
...ector/src/simcore_service_director/docker_utils.py 86.20% <100.00%> (ø)
...director/src/simcore_service_director/resources.py 100.00% <100.00%> (ø)
...ctor/src/simcore_service_director/rest/__init__.py 100.00% <100.00%> (ø)
...ctor/src/simcore_service_director/rest/handlers.py 63.41% <100.00%> (ø)
...erver/src/simcore_service_webserver/rest_models.py 0.00% <0.00%> (-91.18%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6ff86...cfa5dc1. Read the comment docs.

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label May 19, 2020
@pcrespov pcrespov requested review from sanderegg and GitHK and removed request for sanderegg May 19, 2020 14:02
@pcrespov pcrespov marked this pull request as ready for review May 19, 2020 14:02
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new scrip to update dependencies

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov force-pushed the maintenance/dependencies branch from 74ad32f to 1eae7d3 Compare May 20, 2020 09:17
@pcrespov pcrespov force-pushed the maintenance/dependencies branch from 1eae7d3 to cfa5dc1 Compare May 20, 2020 12:13
@pcrespov pcrespov merged commit 358f3b7 into ITISFoundation:master May 20, 2020
@pcrespov pcrespov deleted the maintenance/dependencies branch May 20, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants