Skip to content

Fix thumbnails #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2020
Merged

Fix thumbnails #1514

merged 1 commit into from
May 19, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 19, 2020 •
edited
Loading

What do these changes do?

The importance of parentheses.

image

@odeimaiz odeimaiz self-assigned this May 19, 2020
@codecov
Copy link

codecov bot commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #1514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1514   +/-   ##
=======================================
  Coverage   71.26%   71.26%           
=======================================
  Files         247      247           
  Lines        9977     9977           
  Branches     1098     1098           
=======================================
  Hits         7110     7110           
  Misses       2555     2555           
  Partials      312      312
Flag Coverage Δ
#integrationtests 57.94% <ø> (ø)
#unittests 63.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17c30b...f203c99. Read the comment docs.

KZzizzle
KZzizzle approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful use of parentheses

GitHK
GitHK approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanderegg
sanderegg approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!

@pcrespov pcrespov merged commit 6652c07 into ITISFoundation:master May 19, 2020
@sanderegg sanderegg mentioned this pull request May 26, 2020
Merged
@odeimaiz odeimaiz deleted the feature/fix-thumbnails branch August 18, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@KZzizzle KZzizzle KZzizzle approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

Assignees

@odeimaiz odeimaiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @GitHK @KZzizzle @pcrespov @sanderegg