[bugfix] Fix for is1499

.gitignore

@@ -149,3 +149,6 @@ prof/
 
 # outputs from make
 .stack-*.yml
+
+# coverage for e2e testing
+coverage/

services/web/client/source/class/osparc/auth/LoginPage.js

@@ -92,7 +92,12 @@ qx.Class.define("osparc.auth.LoginPage", {
       login.resetValues();
     }, this);
 
-    [register, resetRequest, reset].forEach(srcPage => {
+    register.addListener("done", msg => {
+      osparc.utils.Utils.cookie.deleteCookie("user");
+      this.fireDataEvent("done", msg);
+    });
+
+    [resetRequest, reset].forEach(srcPage => {
       srcPage.addListener("done", msg => {
         pages.setSelection([login]);
         srcPage.resetValues();

services/web/client/source/class/osparc/auth/Manager.js

@@ -108,20 +108,14 @@ qx.Class.define("osparc.auth.Manager", {
         .finally(this.__logoutUser());
     },
 
-    register: function(userData, successCbk, failCbk, context) {
-      console.debug("Registering user ...");
+    register: function(userData) {
       const params = {
         data: userData
       };
-      osparc.data.Resources.fetch("auth", "postRegister", params)
-        .then(data => {
-          successCbk.call(context, data);
-        })
-        .catch(err => failCbk.call(context, err.message));
+      return osparc.data.Resources.fetch("auth", "postRegister", params);
     },
 
     resetPasswordRequest: function(email, successCbk, failCbk, context) {
-      console.debug("Requesting reset password ...");
       const params = {
         data: {
           email
@@ -135,7 +129,6 @@ qx.Class.define("osparc.auth.Manager", {
     },
 
     resetPassword: function(newPassword, confirmation, code, successCbk, failCbk, context) {
-      console.debug("Reseting password ...");
       const params = {
         url: {
           code

services/web/client/source/class/osparc/auth/ui/RegistrationView.js

@@ -54,12 +54,6 @@ qx.Class.define("osparc.auth.ui.RegistrationView", {
         email.activate();
       });
 
-      // const uname = new qx.ui.form.TextField().set({
-      //   required: true,
-      //   placeholder: this.tr("Introduce a user name")
-      // });
-      // this.add(uname);
-
       const pass1 = new qx.ui.form.PasswordField().set({
         required: true,
         placeholder: this.tr("Introduce a password")
@@ -88,7 +82,6 @@ qx.Class.define("osparc.auth.ui.RegistrationView", {
         return osparc.auth.core.Utils.checkSamePasswords(pass1, pass2);
       });
 
-
       // submit & cancel buttons
       const grp = new qx.ui.container.Composite(new qx.ui.layout.HBox(10));
 
@@ -123,21 +116,15 @@ qx.Class.define("osparc.auth.ui.RegistrationView", {
     },
 
     __submit: function(userData) {
-      console.debug("Registering new user");
-
-      let manager = osparc.auth.Manager.getInstance();
-
-      let successFun = function(log) {
-        this.fireDataEvent("done", log.message);
-        osparc.component.message.FlashMessenger.getInstance().log(log);
-      };
-
-      let failFun = function(msg) {
-        msg = msg || this.tr("Cannot register user");
-        osparc.component.message.FlashMessenger.getInstance().logAs(msg, "ERROR");
-      };
-
-      manager.register(userData, successFun, failFun, this);
+      osparc.auth.Manager.getInstance().register(userData)
+        .then(log => {
+          this.fireDataEvent("done", log.message);
+          osparc.component.message.FlashMessenger.getInstance().log(log);
+        })
+        .catch(err => {
+          const msg = err.message || this.tr("Cannot register user");
+          osparc.component.message.FlashMessenger.getInstance().logAs(msg, "ERROR");
+        });
     },
 
     _onAppear: function() {

tests/e2e/README.md

@@ -0,0 +1,26 @@
+## To run the tests locally
+```bash
+npm install
+npm test
+```
+## To debug the tests locally with VSCode
+Add the following configuration to your local ``launch.json``:
+```json
+{
+  "type": "node",
+  "request": "launch",
+  "name": "Debug e2e tests",
+  "runtimeArgs": [
+    "--inspect-brk",
+    "${workspaceRoot}/tests/e2e/node_modules/.bin/jest",
+    "--runInBand",
+    "--colors"
+  ],
+  "cwd": "${workspaceFolder}/tests/e2e",
+  "restart": true,
+  "console": "integratedTerminal",
+  "internalConsoleOptions": "neverOpen",
+  "port": 9229
+}
+```
+Now you can run the tests by clicking on the Play button, using that configuration. It should allow you to insert breakpoints and inspect variables.

tests/e2e/tests/register.test.js

@@ -10,7 +10,7 @@ beforeAll(async () => {
   await page.goto(url);
 }, ourTimeout);
 
-test('Register, Log In and Log Out', async () => {
+test('Register and Log Out', async () => {
   page.on('response', async response => {
     if (response.url().endsWith("/config")) {
       try {
@@ -55,6 +55,6 @@ test('Register, Log In and Log Out', async () => {
       }
     }
   });
-  await auto.logIn(page, user, pass);
+
   await auto.logOut(page);
 }, 30000);

tests/e2e/tests/startupCalls.test.js

@@ -8,18 +8,15 @@ const {
 
 beforeAll(async () => {
   await page.goto(url);
-
   await auto.register(page, user, pass);
-  await auto.logIn(page, user, pass);
+  await page.waitFor(1000);
 }, ourTimeout);
 
 afterAll(async () => {
   await auto.logOut(page);
 }, ourTimeout);
 
 describe('Calls after logging in', () => {
-  page.waitFor(1000);
-
   test('Profile', async () => {
     const responseEnv = await utils.fetch('me');
     expect(responseEnv.data["login"]).toBe(user);