[bugfix] Fix for is1499 #1516
Merged
[bugfix] Fix for is1499 #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
- Coverage 70.89% 70.88% -0.01%
==========================================
Files 249 249
Lines 10097 10097
Branches 1114 1114
==========================================
- Hits 7158 7157 -1
- Misses 2617 2618 +1
Partials 322 322
Continue to review full report at Codecov.
|
|
I will PR the fix for the e2e |
pcrespov
requested changes
May 25, 2020
.gitignore
Outdated
| @@ -149,3 +149,7 @@ prof/ | |||
|
|
|||
| # outputs from make | |||
| .stack-*.yml | |||
|
|
|||
There was a problem hiding this comment.
MINOR: For non-generics, I prefer if we create a specific .gitignore ... e.g. in this case it would be in tests/e2e/.gitignore
| Add the following configuration to your local ``launch.json``: | ||
| ```json | ||
| { | ||
| "type": "node", |
There was a problem hiding this comment.
This is very nice but It would even be better if you add it in .vscode-template/lauch.json ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix the reported problem with login after registering a user.
BONUS: Corrected bugs with not closing the feedback dialog when clicking continue and the rotating Idle icon.
Related issue number
closes #1499
How to test
Just register a user and check that it is redirected to the dashboard.
Checklist