Skip to content

UI/UX: Thumbnail and loading iframe #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 26, 2020
Merged

UI/UX: Thumbnail and loading iframe #1524

merged 25 commits into from
May 26, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 23, 2020 •
edited
Loading

What do these changes do?

  • Bug fixed. PointerEvent Position was wrong when the window was not maximized.
  • Created new class that takes care of scaling and aligning images in the middle and center. Used in the StudyBrowser sheets and StudyInfo.
  • "Starting Service" message now bounds node's Interactive Status + Label.

Aligned thumbnails:
image
image
image

Loading info:
Starting

Related issues

closes #1518
related #1520

@odeimaiz odeimaiz self-assigned this May 23, 2020
@codecov
Copy link

codecov bot commented May 23, 2020 •
edited
Loading

Codecov Report

Merging #1524 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1524   +/-   ##
=======================================
  Coverage   70.88%   70.89%           
=======================================
  Files         249      249           
  Lines       10097    10097           
  Branches     1114     1114           
=======================================
+ Hits         7157     7158    +1     
+ Misses       2618     2617    -1     
  Partials      322      322
Flag Coverage Δ
#integrationtests 57.74% <ø> (ø)
#unittests 62.91% <ø> (+<0.01%) ⬆️
Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 65.32% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70285c...ad740c4. Read the comment docs.

@odeimaiz odeimaiz added this to the Chrigel Maurer milestone May 25, 2020
@odeimaiz odeimaiz changed the title WIP: Monday demo II UI/UX: May 25, 2020
@odeimaiz odeimaiz changed the title UI/UX: WIP UI/UX: May 25, 2020
@odeimaiz odeimaiz changed the title WIP UI/UX: [WIP] UI/UX: May 25, 2020
@odeimaiz odeimaiz marked this pull request as ready for review May 25, 2020 17:22
@odeimaiz odeimaiz changed the title [WIP] UI/UX: UI/UX: Thumbnail and loading iframe May 25, 2020
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label May 25, 2020
sanderegg
sanderegg approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff!!

@odeimaiz odeimaiz merged commit a75a741 into ITISFoundation:master May 26, 2020
@sanderegg sanderegg mentioned this pull request May 26, 2020
Merged
@odeimaiz odeimaiz deleted the feature/monday-demo branch August 18, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignapas ignapas ignapas approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Chrigel Maurer
Development

Successfully merging this pull request may close these issues.

Fix aspect ratio of images in Sudy Details Editor window
3 participants
@odeimaiz @ignapas @sanderegg