-
Notifications
You must be signed in to change notification settings - Fork 28
[maintenance] Various improvements on logs to assist debugging #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maintenance] Various improvements on logs to assist debugging #1763
Conversation
f0ad88b
to
85345c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1763 +/- ##
======================================
Coverage 71.9% 71.9%
======================================
Files 302 303 +1
Lines 11718 11755 +37
Branches 1271 1271
======================================
+ Hits 8427 8461 +34
- Misses 2949 2951 +2
- Partials 342 343 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
282d044
to
d30aecf
Compare
e5e44c2
to
0a87bf6
Compare
00c8cda
to
f3ef49a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a few questions/personal doubts.
services/web/server/src/simcore_service_webserver/projects/projects_db.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments but that's it. 👍
services/web/server/src/simcore_service_webserver/computation_api.py
Outdated
Show resolved
Hide resolved
eb660be
to
fa67d05
Compare
…nted into log upon startup
8a07506
to
4b05310
Compare
"log-timestamp" library was NOT installed in the e2e environment, therefore it has been failing since it came in... If necessary, it should be added to the puppeteer base image |
What do these changes do?
Small fixes and improvements while debugging #1752 ...
e2e
webserver
sidecar
requirements
Related issue number
#1752
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)