Skip to content

[maintenance] Various improvements on logs to assist debugging #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 9, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 1, 2020

What do these changes do?

Small fixes and improvements while debugging #1752 ...

e2e

  • timeout logs to avoid e2e hanging while creating docker logs
  • logs print time-stamps

webserver

  • Adds app settings [add pydantic (will replace traferet in a new PR) ]
  • More metadata: passes build and git commit versions
  • Public metadata published via static.json to the front-end and in v0/config entrypoint
  • Settings logged in console for reference purposes
  • cleanup

sidecar

  • cleanup

requirements

Related issue number

#1752

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov force-pushed the is1752/sleepers-fail branch from f0ad88b to 85345c8 Compare September 1, 2020 07:50
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1763 into master will increase coverage by 0.0%.
The diff coverage is 89.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1763   +/-   ##
======================================
  Coverage    71.9%   71.9%           
======================================
  Files         302     303    +1     
  Lines       11718   11755   +37     
  Branches     1271    1271           
======================================
+ Hits         8427    8461   +34     
- Misses       2949    2951    +2     
- Partials      342     343    +1     
Flag Coverage Δ
#integrationtests 57.1% <70.9%> (+0.1%) ⬆️
#unittests 66.0% <85.4%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ices/sidecar/src/simcore_service_sidecar/config.py 100.0% <ø> (ø)
...webserver/computation_comp_tasks_listening_task.py 56.2% <0.0%> (ø)
...re_service_webserver/projects/projects_handlers.py 90.2% <0.0%> (ø)
...vices/sidecar/src/simcore_service_sidecar/utils.py 81.9% <100.0%> (ø)
...erver/src/simcore_service_webserver/__version__.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/application.py 95.0% <100.0%> (+0.1%) ⬆️
.../simcore_service_webserver/computation_handlers.py 87.7% <100.0%> (ø)
.../simcore_service_webserver/projects/projects_db.py 83.5% <100.0%> (+<0.1%) ⬆️
...ver/src/simcore_service_webserver/rest_handlers.py 100.0% <100.0%> (ø)
...b/server/src/simcore_service_webserver/settings.py 100.0% <100.0%> (ø)
... and 3 more

@pcrespov pcrespov force-pushed the is1752/sleepers-fail branch 2 times, most recently from 282d044 to d30aecf Compare September 4, 2020 16:37
@pcrespov pcrespov self-assigned this Sep 4, 2020
@pcrespov pcrespov force-pushed the is1752/sleepers-fail branch from e5e44c2 to 0a87bf6 Compare September 4, 2020 17:13
@pcrespov pcrespov requested review from sanderegg and GitHK September 7, 2020 16:25
@pcrespov pcrespov changed the title WIP: Is1752/sleepers fail Various improvements on logs to assist debugging Sep 7, 2020
@pcrespov pcrespov changed the title Various improvements on logs to assist debugging WIP: Various improvements on logs to assist debugging Sep 7, 2020
@pcrespov pcrespov force-pushed the is1752/sleepers-fail branch from 00c8cda to f3ef49a Compare September 7, 2020 16:26
@pcrespov pcrespov added a:sidecar issue related with the sidecar worker service a:webserver issue related to the webserver service dependencies t:maintenance Some planned maintenance work labels Sep 7, 2020
@pcrespov pcrespov changed the title WIP: Various improvements on logs to assist debugging [maintenance] Various improvements on logs to assist debugging Sep 7, 2020
@pcrespov pcrespov marked this pull request as ready for review September 7, 2020 17:08
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few questions/personal doubts.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments but that's it. 👍

@pcrespov pcrespov force-pushed the is1752/sleepers-fail branch 2 times, most recently from eb660be to fa67d05 Compare September 9, 2020 13:01
@pcrespov pcrespov force-pushed the is1752/sleepers-fail branch from 8a07506 to 4b05310 Compare September 9, 2020 17:16
@pcrespov pcrespov merged commit ec24c7e into ITISFoundation:master Sep 9, 2020
@pcrespov pcrespov deleted the is1752/sleepers-fail branch September 9, 2020 17:34
@odeimaiz
Copy link
Member

"log-timestamp" library was NOT installed in the e2e environment, therefore it has been failing since it came in...

If necessary, it should be added to the puppeteer base image

@pcrespov pcrespov added this to the Nephelai milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:sidecar issue related with the sidecar worker service a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants