Skip to content

Bump isort from 5.4.2 to 5.5.1 in /packages/service-library #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps isort from 5.4.2 to 5.5.1.

Release notes

Sourced from isort's releases.

5.5.1 September 4, 2020

  • Fixed #1454: Ensure indented import sections with import heading and a preceding comment don't cause import sorting loops.
  • Fixed #1453: isort error when float to top on almost empty file.
  • Fixed #1456 and #1415: noqa comment moved to where flake8 cant see it.
  • Fixed #1460: .svn missing from default ignore list.

5.5.0 September 3, 2020

  • Fixed #1398: isort: off comment doesn't work, if it's the top comment in the file.
  • Fixed #1395: reverse_relative setting doesn't have any effect when combined with force_sort_within_sections.
  • Fixed #1399: --skip can error in the case of projects that contain recursive symlinks.
  • Fixed #1389: ensure_newline_before_comments doesn't work if comment is at top of section and sections don't have lines between them.
  • Fixed #1396: comments in imports with ";" can keep isort from recognizing import line.
  • Fixed #1380: As imports removed when combine_star is set.
  • Fixed #1382: --float-to-top has no effect if no import is already at the top.
  • Fixed #1420: isort never settles on module docstring + add import.
  • Fixed #1421: Error raised when repo contains circular symlinks.
  • Fixed #1427: noqa comment is moved from star import to constant import.
  • Fixed #1444 & 1445: Incorrect placement of import additions.
  • Fixed #1447: isort5 throws error when stdin used on Windows with deprecated args.
  • Implemented #1397: Added support for specifying config file when using git hook (thanks @diseraluca!).
  • Implemented #1405: Added support for coloring diff output.
  • Implemented #1434: New multi-line grid mode without parentheses.

Goal Zero (Tickets related to aspirational goal of achieving 0 regressions for remaining 5.0.0 lifespan):

  • Implemented #1392: Extensive profile testing.
  • Implemented #1393: Proprety based testing applied to code snippets.
  • Implemented #1391: Create automated integration test that includes full code base of largest OpenSource isort users.

Potentially breaking changes:

  • Fixed #1429: --check doesn't print to stderr as the documentation says. This means if you were looking for ERROR: messages for files that contain incorrect imports within stdout you will now need to look in stderr.
Changelog

Sourced from isort's changelog.

5.5.1 September 4, 2020

  • Fixed #1454: Ensure indented import sections with import heading and a preceding comment don't cause import sorting loops.
  • Fixed #1453: isort error when float to top on almost empty file.
  • Fixed #1456 and #1415: noqa comment moved to where flake8 cant see it.
  • Fixed #1460: .svn missing from default ignore list.

5.5.0 September 3, 2020

  • Fixed #1398: isort: off comment doesn't work, if it's the top comment in the file.
  • Fixed #1395: reverse_relative setting doesn't have any effect when combined with force_sort_within_sections.
  • Fixed #1399: --skip can error in the case of projects that contain recursive symlinks.
  • Fixed #1389: ensure_newline_before_comments doesn't work if comment is at top of section and sections don't have lines between them.
  • Fixed #1396: comments in imports with ";" can keep isort from recognizing import line.
  • Fixed #1380: As imports removed when combine_star is set.
  • Fixed #1382: --float-to-top has no effect if no import is already at the top.
  • Fixed #1420: isort never settles on module docstring + add import.
  • Fixed #1421: Error raised when repo contains circular symlinks.
  • Fixed #1427: noqa comment is moved from star import to constant import.
  • Fixed #1444 & 1445: Incorrect placement of import additions.
  • Fixed #1447: isort5 throws error when stdin used on Windows with deprecated args.
  • Implemented #1397: Added support for specifying config file when using git hook (thanks @diseraluca!).
  • Implemented #1405: Added support for coloring diff output.
  • Implemented #1434: New multi-line grid mode without parentheses.

Goal Zero (Tickets related to aspirational goal of achieving 0 regressions for remaining 5.0.0 lifespan):

  • Implemented #1392: Extensive profile testing.
  • Implemented #1393: Proprety based testing applied to code snippets.
  • Implemented #1391: Create automated integration test that includes full code base of largest OpenSource isort users.

Potentially breaking changes:

  • Fixed #1429: --check doesn't print to stderr as the documentation says. This means if you were looking for ERROR: messages for files that contain incorrect imports within stdout you will now need to look in stderr.
Commits
  • 6a3cc76 Bump version to 5.5.1
  • 2e56a2d Merge pull request #1462 from PyCQA/issue/1456/ensure-no-qa-comments-are-visible
  • 434abbf Formatting
  • 2d823d2 Resolve #1460: Exclude svn and bzr repo files by default
  • 5d984fc Merge pull request #1458 from PyCQA/issue/1454/fix-endless-import-sorting
  • 6ac179a Fix issue #1454: Endless import sorting for indendent imports with section he...
  • 95f32e4 Merge pull request #1457 from PyCQA/issue/1453/float-to-top-errors-with-empty...
  • 0c34b98 Resolve #1453: isort error when float to top on almost empty file. Ensure err...
  • ff0d436 Add new contributors from 5.5.0 release
  • c1a76c5 Add Matěj Nikl (@MatejNikl) to acknowledgement list for his help uncovering s...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #1774 into master will decrease coverage by 1.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1774     +/-   ##
========================================
- Coverage    71.7%   69.7%   -2.0%     
========================================
  Files         302     302             
  Lines       11742   11742             
  Branches     1274    1274             
========================================
- Hits         8422    8188    -234     
- Misses       2978    3234    +256     
+ Partials      342     320     -22     
Flag Coverage Δ
#integrationtests 56.0% <ø> (-0.9%) ⬇️
#unittests 65.7% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/sidecar/src/simcore_service_sidecar/executor.py 23.2% <0.0%> (-56.8%) ⬇️
...rvices/sidecar/src/simcore_service_sidecar/core.py 27.2% <0.0%> (-43.2%) ⬇️
services/sidecar/src/simcore_service_sidecar/db.py 52.0% <0.0%> (-40.0%) ⬇️
...vices/sidecar/src/simcore_service_sidecar/utils.py 54.2% <0.0%> (-27.8%) ⬇️
...ervices/sidecar/src/simcore_service_sidecar/cli.py 47.2% <0.0%> (-19.5%) ⬇️
.../sidecar/src/simcore_service_sidecar/log_parser.py 64.9% <0.0%> (-16.9%) ⬇️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 86.7% <0.0%> (-4.5%) ⬇️
.../director/src/simcore_service_director/producer.py 60.6% <0.0%> (+0.4%) ⬆️

@pcrespov
Copy link
Member

pcrespov commented Sep 7, 2020

Duplicated in #1763
@dependabot close

@dependabot-preview dependabot-preview bot deleted the dependabot/pip/packages/service-library/isort-5.5.1 branch September 7, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant