-
Notifications
You must be signed in to change notification settings - Fork 28
director OpenAPI, refactoring #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sanderegg
merged 421 commits into
ITISFoundation:master
from
sanderegg:ITISFoundation/osparc-simcore#185
Sep 13, 2018
Merged
director OpenAPI, refactoring #187
sanderegg
merged 421 commits into
ITISFoundation:master
from
sanderegg:ITISFoundation/osparc-simcore#185
Sep 13, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-simcore into feature/prj_model_w_server
…_project_model Feature#213 adapt server to new project model
Feature/prj model w server
…c-simcore into feature/prj_model_w_server
Feature/prj model w server
…c-simcore into feature/prj_model_w_server
Feature/prj model w server
…will need to be reworked later on.
…ith the real tag.
odeimaiz
approved these changes
Sep 13, 2018
This was referenced Nov 2, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Refactoring of the director REST API using the openapi protocol and API first paradigm.
Also implies migrating FLASK based server to AIOHTTP
define open API v3.0 following good practices (use resource names without verbs, ...), separated in several files to allow re-use
use node-meta-v0.0.1.json as defined in link New User and Project Models (schemas) #148
Server side:
Client side:
Webserver:
Webclient:
NOTE: validate openapi responses currently has an issue when using the external json-schema reference. wating for an answer from openapi-core
NOTE2: currently the json-schema is a copy from here
Related issue number
connects #185, connects #196
fixes #213, fixes #197
Checklist
@pcrespov , @mguidon