Skip to content

Adapt server to new project model #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
pcrespov opened this issue Sep 11, 2018 · 0 comments · Fixed by #187
Closed
2 tasks done

Adapt server to new project model #213

pcrespov opened this issue Sep 11, 2018 · 0 comments · Fixed by #187
Assignees
@sanderegg
Milestone
Libra

Comments

@pcrespov
Copy link
Member

pcrespov commented Sep 11, 2018 •
edited by sanderegg
Loading

child of #148.

  • correct implementation of server handle function (comp_backend_api.py)
    • convert new schema to old schema as a temporary fix to allow the platform to run as before
@pcrespov pcrespov added this to the Libra milestone Sep 11, 2018
pcrespov pushed a commit to pcrespov/osparc-simcore that referenced this issue Sep 11, 2018
Squashed PR 187 before merged to master.
a4397a4 
- Merging bulk changes
- Director with openapi that includes new data model.
- Only missing is adapting business loging to new data model (see issue ITISFoundation#213)
This was referenced Sep 12, 2018
Closed
Merged
Merged
@ghost ghost removed the in progress label Sep 13, 2018
This was referenced Sep 18, 2018
Merged
Merged
pcrespov added a commit that referenced this issue Sep 25, 2018
@pcrespov
Is#186/web server api (#208)
c3e3bc4 
- [x] adds rest-api following same procedure as in director (see #185)
- [x] wait director integration before merging (requires #185)
- [x] webserver-sdk 
- [x] mockup logic (business logic will be added later)
- [x] adds infrastructure for testing
- [x] sessions, security, configuration, resources (draft)


commit c0bc7d6
Author: Pedro Crespo <[email protected]>
Date:   Thu Aug 30 11:53:41 2018 +0200

    Fixes access to docker socket:
     - cleanup Dockerfile
     - minor doc and logs

commit 7f07022
Author: Pedro Crespo <[email protected]>
Date:   Wed Aug 29 15:52:16 2018 +0200

    sidecar: starts as root (via entrypoint) but runs as scu (non-root)

commit 90359c4
Author: Pedro Crespo <[email protected]>
Date:   Wed Aug 29 15:51:32 2018 +0200

    Fixes sidecar: temporary fix to connection to other services

commit 7619671
Author: Pedro Crespo <[email protected]>
Date:   Wed Aug 29 15:44:42 2018 +0200

    Fixes host in server running inside a docker

commit 83e492d
Author: Pedro Crespo <[email protected]>
Date:   Wed Aug 29 13:46:55 2018 +0200

    Fixes on web server:
     - removed usused cs_s4l from config
     - added env for rabbit

commit a5d8220
Author: Pedro Crespo <[email protected]>
Date:   Tue Aug 28 22:06:59 2018 +0200

    Implements entry in #186: - upgrades Dockerfile with .venv and pip installing 3rd parties

commit 3c55bf3
Author: Pedro Crespo <[email protected]>
Date:   Tue Aug 28 18:46:57 2018 +0200

    Setting up boot for web service and forgot configs

commit 8003744
Author: Pedro Crespo <[email protected]>
Date:   Tue Aug 28 18:40:12 2018 +0200

    Adding config data and retrieving it as resource

commit 94de3d7
Author: Pedro Crespo <[email protected]>
Date:   Tue Aug 28 10:58:02 2018 +0200

    Minor changes in docker after discussion with MaG


commit 752c7bf
Author: Pedro Crespo <[email protected]>
Date:   Mon Aug 27 19:49:39 2018 +0200

    WIP #198: non-root user
     - all volumes bound to /home/scu
     - All modules pip installed (in dev w/ edit mode).
     - All files produce in dev mode on bound volumes are not deletable
     - Production stage is further optimized by taking only venv from base
     - Fixes sidecar access to input/output/log volumes

commit ec755bc
Author: Pedro Crespo <[email protected]>
Date:   Fri Aug 24 21:53:13 2018 +0200

    WIP #198:
     - added a boot.sh script to start celery worker
     - restructured package submodules. Otherwise got error (see comments in #198)
     -

commit a27a279
Author: Pedro Crespo <[email protected]>
Date:   Fri Aug 24 20:24:49 2018 +0200

    WIP #198: setup for sidecar
     - created setup and requirements for dev&prod
     - installs package in docker (instead of reference via sys.path). this way all third-parties are installed.
     - minor cleanup of code

* is#186 web: Normalized package name and added new placeholders for submodules
* is#186 web: Normalized package name and added new placeholders for submodules
* is#186 web: fix import in docker context
 - temporarily a thick production stage
 - boot and entrypoint sh to .docker/
- separated middlewares, routing and setup
- merged api submodule into rest - removed aiohttp swagger since already in apiset - split rest/handlers
- web api: moved routings into separate functions
- Allowed disabling services from configuration
- Fixes cyclic import rest.routing -> rest.settings
- Fixes fix bug1 in issue #186 using a decorator
- Testing authentication
- added a light/fast test config
- simple test unauthorized access
- imp#186: Route to retrieve openapi specs json /v1/oas
- Fixes test_rest to access to api specs.
- Fixes coverage failure reported in travis
- Simplified resources functionality and updated tests
- Squashed PR 187 before merged to master.
- Merging bulk changes
- Director with openapi that includes new data model.
- Only missing is adapting business loging to new data model (see issue #213)
- Added test to check openapi specs
- Change first oas.server to overcome client-sdk limitation
- Added autogenerated code for webserver-sdk. Added some ignores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanderegg sanderegg

Labels
None yet
Projects
None yet
Milestone
Libra
Development

Successfully merging a pull request may close this issue.

director OpenAPI, refactoring sanderegg/osparc-simcore
2 participants
@pcrespov @sanderegg