-
Notifications
You must be signed in to change notification settings - Fork 29
Fixes on catalog/services
section of the web-API
#2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2151 +/- ##
========================================
+ Coverage 73.1% 77.0% +3.9%
========================================
Files 464 249 -215
Lines 17709 10326 -7383
Branches 1741 1019 -722
========================================
- Hits 12946 7957 -4989
+ Misses 4313 2053 -2260
+ Partials 450 316 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9f0d4fa
to
064b086
Compare
catalog/services
section of the web-API
catalog/services
section of the web-APIcatalog/services
section of the web-API
catalog/services
section of the web-APIcatalog/services
section of the web-API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We partially discussed together and I thought we agreed that exlude_none is not good.
if you have a field that can be nullable but has a default of 2 for example. say I set None, then on export this field will disappear and when it comes back it will set as 2 by default.
services/catalog/src/simcore_service_catalog/api/routes/services.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/catalog_api_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/catalog_api_handlers.py
Show resolved
Hide resolved
Adds tests for models
Adds tests on replacement
Fixes tests
…t as reliable as openapi-generator validator
7f94db0
to
23fec93
Compare
…r redemption :-)
…r responses Units are formatted ONLY when provided
What do these changes do?
Requests in the
catalog/services
section of the web-API are validated in the webserver and forwarded to the catalog. The responses of the catalog are then again processed in the webserver (adds convenience values for the units) and retransmitted backt o the front-endlist_services
return the same inputs asget_service_input
via the web-APIlist_services
,update_service
andget_service
now have explicit handlersorjson
/catalog/services ...
web API (no need forWEBSERVER_DEV_FEATURES_ENABLED=1
)defaultValue
from output portscatalog service
null
-ed attributes (search forRESPONSE_MODEL_POLICY
)Related issue/s
How to test
/catalog/services/*
entrypointsChecklist
api-server
+web-server
to the catalog service: partially moved models, rest -> Next PRAlleviates database connection load-> Next PRSimplify catalog API models-> Next PRcreate service-fastapi-library-> Next PRmake openapi-specs
,git commit ...
and thenmake version-*
)