-
Notifications
You must be signed in to change notification settings - Fork 28
reduce traefik latency check, and remove unnecessary warnings when a pipeline does not exist #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2224 +/- ##
========================================
- Coverage 73.0% 73.0% -0.1%
========================================
Files 465 465
Lines 17978 17983 +5
Branches 1773 1773
========================================
- Hits 13137 13133 -4
- Misses 4375 4380 +5
- Partials 466 470 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
8f5f713
to
9482dcb
Compare
services/web/server/src/simcore_service_webserver/projects/projects_db.py
Outdated
Show resolved
Hide resolved
e7e5dfc
to
151a0fb
Compare
validation done when loading from DB filtering of projects done directly after load
services/web/server/src/simcore_service_webserver/projects/projects_db.py
Outdated
Show resolved
Hide resolved
await asyncio.get_event_loop().run_in_executor( | ||
pool, ProjectAtDB.from_orm, row | ||
) | ||
# ProjectAtDB.from_orm(row) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MNIOR: remove commented
Q: does it really make a difference making it async? Did you measure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still getting "some" 503 when the system more so I took no chance.
What do these changes do?
reduce warning logs pollution
Related issue/s
How to test
Checklist