Skip to content

reduce traefik latency check, and remove unnecessary warnings when a pipeline does not exist #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 23, 2021

Conversation

sanderegg
Copy link
Member

What do these changes do?

reduce warning logs pollution

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Mar 21, 2021
@sanderegg sanderegg added this to the The Red Panda milestone Mar 21, 2021
@sanderegg sanderegg self-assigned this Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #2224 (c073dd3) into master (aa717c7) will decrease coverage by 0.0%.
The diff coverage is 65.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2224     +/-   ##
========================================
- Coverage    73.0%   73.0%   -0.1%     
========================================
  Files         465     465             
  Lines       17978   17983      +5     
  Branches     1773    1773             
========================================
- Hits        13137   13133      -4     
- Misses       4375    4380      +5     
- Partials      466     470      +4     
Flag Coverage Δ
integrationtests 65.4% <65.2%> (-0.1%) ⬇️
unittests 66.4% <60.8%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/application.py 93.0% <0.0%> (ø)
...erver/src/simcore_service_webserver/director_v2.py 86.6% <50.0%> (-1.5%) ⬇️
.../simcore_service_webserver/projects/projects_db.py 89.3% <62.5%> (-1.4%) ⬇️
...re_service_webserver/projects/projects_handlers.py 83.7% <100.0%> (+0.4%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 84.9% <0.0%> (-3.3%) ⬇️
.../director/src/simcore_service_director/producer.py 60.8% <0.0%> (-0.9%) ⬇️
.../server/src/simcore_service_webserver/users_api.py 93.9% <0.0%> (+2.5%) ⬆️

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

validation done when loading from DB
filtering of projects done directly after load
@sanderegg sanderegg changed the title remove unnecessary warnings when a pipeline does not exist reduce traefik latency check, and remove unnecessary warnings when a pipeline does not exist Mar 22, 2021
@sanderegg sanderegg requested a review from pcrespov March 22, 2021 21:51
await asyncio.get_event_loop().run_in_executor(
pool, ProjectAtDB.from_orm, row
)
# ProjectAtDB.from_orm(row)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MNIOR: remove commented

Q: does it really make a difference making it async? Did you measure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting "some" 503 when the system more so I took no chance.

@sanderegg sanderegg merged commit 5a9bd74 into ITISFoundation:master Mar 23, 2021
@sanderegg sanderegg deleted the improve_logging branch March 23, 2021 08:13
@sanderegg sanderegg mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants