Skip to content

WIP - persistent iframe class #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

WIP - persistent iframe class #296

wants to merge 9 commits into from

Conversation

oetiker
Copy link
Contributor

@oetiker oetiker commented Nov 1, 2018 •
edited
Loading

What do these changes do?

keep the iframe outside of the actual widget to prevent it from reloading as the iframe widget or any of its parents are moved around the dom.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@ghost ghost assigned oetiker Nov 1, 2018
@ghost ghost added the review label Nov 1, 2018
@pcrespov pcrespov changed the title persistent iframe class WIP - persistent iframe class Nov 1, 2018
@pcrespov pcrespov changed the title persistent iframe class WIP - persistent iframe class Nov 1, 2018
@ghost ghost assigned odeimaiz Nov 6, 2018
@oetiker oetiker requested a review from odeimaiz November 6, 2018 14:36
@odeimaiz odeimaiz mentioned this pull request Nov 7, 2018
Merged
@odeimaiz
Copy link
Member

odeimaiz commented Nov 8, 2018

@oetiker, this one can be closed, right?

@oetiker
Copy link
Contributor Author

oetiker commented Nov 8, 2018

yes :)

@oetiker oetiker closed this Nov 8, 2018
@ghost ghost removed the review label Nov 8, 2018
@oetiker oetiker deleted the persistant-iframe branch November 8, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeimaiz odeimaiz odeimaiz approved these changes

Assignees

@oetiker oetiker

@odeimaiz odeimaiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oetiker @odeimaiz