Skip to content

NodeModel owns persistentIFrame #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 209 commits into from
Nov 8, 2018
Merged

NodeModel owns persistentIFrame #316

merged 209 commits into from
Nov 8, 2018

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 7, 2018 •
edited
Loading

includes #296

Features:

  • Use persistent iFrame
  • "Loading OSPARC..." site can be shown (it should only be shown for those dynamic services that will provide an iFrame. There is no way to know that at the moment, so it is never shown)
  • Place iFrame together with settings
  • Button for maximizing and restoring iframe
  • Button for restarting iFrame

image

oetiker and others added 30 commits June 13, 2018 09:31
@oetiker
initial
9f8ffd4
@oetiker
first complete schema
bc72477
@oetiker
renamed
05a998c
@oetiker
renamed
013f76a
Initial import of comp. services
1c9800f
Adapt sidecar to dockerfile/compose layout
7e2a2e3
fix requirements
ca2a7ad
@oetiker
Merge branch 'master' into json-schema
52bb450
@oetiker
added key property
5fab282
Add server parts needed for comp. backend
b8f4bb7
@oetiker
added initial Avj wrapper
ca84ccf
rename source --> src
76ab87f
@oetiker
added a little validation test to the main app ...
e84ff9b 
look at the console output when loading it :)
fix publish/subscribe initialization and add up to date mockup data
ba51898
change default indentation for python in vscode-tmplate
80d8b4a
change build context for services such that we can copy files from th…
f3ec478 
…e top level directory
minor cleanup
2edb5fb
change build context for server
2043c59
rename debug to devel
a76d220
Adds code coverage output
8034118
Add local minio for devel and template with credentials
8c46412
update readme
c6fee87
WIP: improving first web/client qx docker. Minor cleanup in compose f…
01b8569 
…iles
@oetiker
fix JS syntax
e9131db
Merge branch 'master' into comp_backend
e4facd8
Improved server/client qx compiler container. - non-root user - dev/p…
2bc95bb 
…rod targets
Renamed web/client dockerfile. Emphasizes that it is only to build th…
8aaa103 
…e client's code
Adds log messages while installing qx contribs
703ad74
Renamed client dockerfile since it is multitarget
92c0d73
Renamed webserver dockerfile since it targets ci
e836528
@ghost ghost assigned odeimaiz Nov 7, 2018
@ghost ghost added the review label Nov 7, 2018
@odeimaiz odeimaiz changed the title WIP - NodeModes owns persistentIFrame WIP - NodeModel owns persistentIFrame Nov 7, 2018
@odeimaiz odeimaiz requested a review from oetiker November 7, 2018 16:58
@odeimaiz odeimaiz changed the title WIP - NodeModel owns persistentIFrame NodeModel owns persistentIFrame Nov 8, 2018
pcrespov
pcrespov reviewed Nov 8, 2018
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot? :-)

@odeimaiz
Copy link
Member Author

odeimaiz commented Nov 8, 2018

@pcrespov screenshot added

@odeimaiz odeimaiz merged commit 63e662c into ITISFoundation:master Nov 8, 2018
@ghost ghost removed the review label Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@oetiker oetiker oetiker approved these changes

@sanderegg sanderegg sanderegg approved these changes

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @oetiker @pcrespov @sanderegg @mguidon