Skip to content

✨ Frontend: Study home page #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jun 15, 2023
Merged

✨ Frontend: Study home page #4360

merged 33 commits into from
Jun 15, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 13, 2023 •
edited by pcrespov
Loading

What do these changes do?

This PR changes the behavior of the clicking on card action. Now a "Details" or "home page", former "More Options", will be opened.

  • Minor improvements to the widget
  • e2e tests updated to follow the new workflow

Bonus

  • Rename Export to Export cMIS @GitHK
  • Password validator's minimum length increased to 12 @mrnicegyu11

PorjectHomePage

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:✨new-feature labels Jun 13, 2023
@odeimaiz odeimaiz added this to the Watermelon milestone Jun 13, 2023
@odeimaiz odeimaiz self-assigned this Jun 13, 2023
@odeimaiz odeimaiz marked this pull request as ready for review June 14, 2023 11:35
mrnicegyu11
mrnicegyu11 approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just came here for the security improvement, thanks

mguidon
mguidon approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

pcrespov
pcrespov approved these changes Jun 14, 2023
View reviewed changes
GitHK
GitHK approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) June 14, 2023 14:17
@mrnicegyu11 mrnicegyu11 mentioned this pull request Jun 14, 2023
Merged
sanderegg
sanderegg reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! somehow we could also show a preview of the workbench in case there are more than 1 node.

@codeclimate
Copy link

codeclimate bot commented Jun 15, 2023

Code Climate has analyzed commit 9f6e8a4 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit f407cf9 into ITISFoundation:master Jun 15, 2023
@odeimaiz odeimaiz deleted the feature/study-home-page branch June 15, 2023 08:35
@odeimaiz odeimaiz mentioned this pull request Jun 20, 2023
Merged
@pcrespov pcrespov mentioned this pull request Jun 21, 2023
Closed
20 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 22, 2023
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@GitHK GitHK GitHK approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mguidon mguidon mguidon approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@SCA-ZMT SCA-ZMT SCA-ZMT approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@elisabettai elisabettai Awaiting requested review from elisabettai

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Watermelon
Development

Successfully merging this pull request may close these issues.
8 participants
@odeimaiz @GitHK @mrnicegyu11 @pcrespov @mguidon @sanderegg @matusdrobuliak66 @SCA-ZMT