Skip to content

✨ Frontend: Preview page: WorkbenchPreview + Thumbnails #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jun 20, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 16, 2023

What do these changes do?

In order to improve the UX for inspecting a Study without opening it, this PR adds a Preview page to the Study details tabsView.

For now, in this view, only accessible for the osparc and s4l products, a preview of the workbench (suggested by @sanderegg in #4360 (review)) and the service's thumbnails are shown together with the nodes tree.

Bonus

Data page was also added to the tabsView.

PreviewPage

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:✨new-feature labels Jun 16, 2023
@odeimaiz odeimaiz added this to the Watermelon milestone Jun 16, 2023
@odeimaiz odeimaiz self-assigned this Jun 16, 2023
@odeimaiz odeimaiz changed the title WIP: ✨ Frontend: Multi thumbnail ✨ Frontend: Multi thumbnail Jun 20, 2023
@odeimaiz odeimaiz marked this pull request as ready for review June 20, 2023 07:56
@odeimaiz odeimaiz changed the title ✨ Frontend: Multi thumbnail ✨ Frontend: Preview page: WorkbenchPreview + Thumbnails Jun 20, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes along nicely. Maybe we could unleash the icon lady?

@odeimaiz odeimaiz enabled auto-merge (squash) June 20, 2023 09:01
@SCA-ZMT
Copy link

SCA-ZMT commented Jun 20, 2023

Looks really cool... so cool in fact, that I would suggest a more standard behavior: the preview shows first when the user clicks on a study, rather than the detailed and verbose (and less intuitive) info with study ID etc.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking cool! I agree with @SCA-ZMT that maybe defaulting on the preview might be what you wanna see most of the time

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very cool and I agree that this can become "default preview" of a Study.

Is here that we might include some markdown editing function for users, so they can edit what is shown?

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@codeclimate
Copy link

codeclimate bot commented Jun 20, 2023

Code Climate has analyzed commit 0176f36 and detected 0 issues on this pull request.

View more on Code Climate.

@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 20, 2023

Very very cool and I agree that this can become "default preview" of a Study.

Is here that we might include some markdown editing function for users, so they can edit what is shown?

@elisabettai @sanderegg @SCA-ZMT
Let's present it at RM and decide what to show by default... I personally think that even though it looks nice (and it will look nicer), we you show the boring Info page.

@elisabettai
What do you mean by the markdown editing function? That's part the Info page, the Description section. We will now add also the comments section below that: #4386

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 20a1b6b into ITISFoundation:master Jun 20, 2023
@odeimaiz odeimaiz deleted the feature/multi-thumbnail branch June 20, 2023 14:06
@elisabettai
Copy link
Collaborator

@elisabettai
What do you mean by the markdown editing function? That's part the Info page, the Description section. We will now add also the comments section below that: #4386

Yes, I was thinking about the Info page and that would fulfill most of the features requested in ITISFoundation/osparc-issues#979.

What are you planning to show next in this Preview? I am just afraid that users might not notice the Preview and put stuff in the Info page only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants