-
Notifications
You must be signed in to change notification settings - Fork 29
✨ Frontend: Preview page: WorkbenchPreview + Thumbnails #4378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Frontend: Preview page: WorkbenchPreview + Thumbnails #4378
Conversation
…simcore into feature/multi-thumbnail
…simcore into feature/multi-thumbnail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes along nicely. Maybe we could unleash the icon lady?
Looks really cool... so cool in fact, that I would suggest a more standard behavior: the preview shows first when the user clicks on a study, rather than the detailed and verbose (and less intuitive) info with study ID etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking cool! I agree with @SCA-ZMT that maybe defaulting on the preview might be what you wanna see most of the time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very cool and I agree that this can become "default preview" of a Study.
Is here that we might include some markdown editing function for users, so they can edit what is shown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Code Climate has analyzed commit 0176f36 and detected 0 issues on this pull request. View more on Code Climate. |
@elisabettai @sanderegg @SCA-ZMT @elisabettai |
Kudos, SonarCloud Quality Gate passed!
|
Yes, I was thinking about the Info page and that would fulfill most of the features requested in ITISFoundation/osparc-issues#979. What are you planning to show next in this |
What do these changes do?
In order to improve the UX for inspecting a Study without opening it, this PR adds a
Preview
page to the Study details tabsView.For now, in this view, only accessible for the
osparc
ands4l
products, a preview of the workbench (suggested by @sanderegg in #4360 (review)) and the service's thumbnails are shown together with the nodes tree.Bonus
Data page was also added to the tabsView.
Related issue/s
How to test
DevOps Checklist