-
Notifications
You must be signed in to change notification settings - Fork 29
✨ Node previews for project homepage #4379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Node previews for project homepage #4379
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4379 +/- ##
=========================================
- Coverage 85.2% 84.5% -0.8%
=========================================
Files 929 429 -500
Lines 39194 22273 -16921
Branches 1006 173 -833
=========================================
- Hits 33427 18822 -14605
+ Misses 5536 3402 -2134
+ Partials 231 49 -182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/web/server/src/simcore_service_webserver/projects/_handlers_project_nodes.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_project_nodes.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_project_nodes.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_project_nodes.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_project_nodes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, please consider my comments.
79e7178
to
105acf0
Compare
For the project wide call, instead of providing a flat list, could you please provide one flat list per node? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 merci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine, just check out my comment
services/web/server/src/simcore_service_webserver/projects/_handlers_project_nodes.py
Outdated
Show resolved
Hide resolved
9366014
to
448070f
Compare
Code Climate has analyzed commit bd957e4 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
|
What do these changes do?
Creates an API to get node's preview files (i.e. pairs thumnails+file url). Current implementation produces fake screenshots (see
how to test
)0.21.0 → 0.22.0
. See openapi.json specsGET projects/{project_id}/nodes/{node_id}/preview
to get a node's previewGET projects/{project_id}/nodes/-/preview
to get a list of all results above . i.e. for allnode_id
s in the projectWEBSERVER_DEV_FEATURES_ENABLED=1
it will return fake homepage infoRelated issue/s
mimetypes.guess_type
works differently in webserver's image #4385How to test
Manual tests:
WEBSERVER_DEV_FEATURES_ENABLED=1
fake
in the label. Them it will be presented as a fake screenshotfile_url
GET projects/*/nodes/*/preview
andGET projects/*/nodes/-/preview
DevOps
None