Skip to content

✨ Previews: 2D images and 3D scenes #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 23, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 23, 2023

What do these changes do?

Implements the frontend part for #4379 and adds a 3D Scene viewer powered by three.js and the GLTFLoader

Depending on the project and node, the backend might provide some 2D images and 3D scenes that will be rendered at the Project home page.

ScenePreview

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this Jun 23, 2023
@odeimaiz odeimaiz changed the title ✨ Previews: images and 3D scenes ✨ Previews: 2D images and 3D scenes Jun 23, 2023
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5140 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5183 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5183 lines exceeds the maximum allowed for the inline comments feature.

@odeimaiz odeimaiz marked this pull request as ready for review June 23, 2023 12:52
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🤩

I like a lot the view for a study with a single node, no neat. With more than one node is trickier.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5183 lines exceeds the maximum allowed for the inline comments feature.

@odeimaiz odeimaiz enabled auto-merge (squash) June 23, 2023 15:23
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5183 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2023

Code Climate has analyzed commit 3b6111c and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit c127b87 into ITISFoundation:master Jun 23, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 12, 2023
36 tasks
@odeimaiz odeimaiz deleted the feature/previews-and-scene branch August 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants