Skip to content

🎨 [Frontend] Credits summary: Show time #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 13, 2024
Merged

🎨 [Frontend] Credits summary: Show time #6356

merged 7 commits into from
Sep 13, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 12, 2024 •
edited by GitHK
Loading

What do these changes do?

  • Show aggregated time in the credits summary view
  • Fix: Increase zIndex so that it goes over the iframes
  • Fix: add offset to tap-off: Last month was not easy to hit

CreditsWithTime

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 12, 2024
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature bug buggy, it does not work as expected labels Sep 12, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 12, 2024 16:30
@odeimaiz odeimaiz enabled auto-merge (squash) September 12, 2024 16:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

matusdrobuliak66
matusdrobuliak66 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sanderegg sanderegg disabled auto-merge September 13, 2024 06:13
@sanderegg sanderegg merged commit 8527559 into ITISFoundation:master Sep 13, 2024
55 checks passed
This was referenced Sep 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@ignapas ignapas Awaiting requested review from ignapas

@SCA-ZMT SCA-ZMT Awaiting requested review from SCA-ZMT

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@pcrespov pcrespov Awaiting requested review from pcrespov

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
No milestone
4 participants
@odeimaiz @GitHK @matusdrobuliak66 @sanderegg